-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: move dnsResolvers to options #13
Conversation
N.b. I renamed |
I wonder if we could take this opportunity to make DNS resolvers more configurable in the stack. Right now the other place we use DNS resolvers is in I think we should:
* = a resolver object rather than a simple list might give us a bit of flexibility to accommodate things like tld-specific resolvers. |
Exposes a `.dns` property on the Helia interface for use with other modules such as @helia/ipns. Refs: ipfs/helia-verified-fetch#13 (comment)
Exposes a `.dns` property on the Helia interface for use with other modules such as @helia/ipns. Refs: ipfs/helia-verified-fetch#13 (comment)
Exposes a `.dns` property on the Helia interface for use with other modules such as @helia/ipns. Refs: ipfs/helia-verified-fetch#13 (comment)
Uses the `.dns` property from #465 to resolve DNS `TXT` records. This allows configuring discrete resolvers for different TLDs, unifies caching across different use of DNS (e.g. dnsaddr multiaddrs), etc. Refs: ipfs/helia-verified-fetch#13 (comment) Fixes: #369 BREAKING CHANGE: requires @helia/interface@4.1.x or later, `resolveDns` has been renamed `resolveDNSLink`
Closing in favour of #18 |
Description
As per ipfs/helia#445 (comment), this PR changes the API of
createVerifiedFetch
so as to allow passing a custom instance of Helia (for example, with a custom blockstore) in addition to customising thednsResolvers
.Notes & open questions
Change checklist