Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose .dns property on @helia/interface #465

Merged
merged 5 commits into from
Mar 13, 2024

Conversation

achingbrain
Copy link
Member

Exposes a .dns property on the Helia interface for use with other modules such as @helia/ipns.

Refs: ipfs/helia-verified-fetch#13 (comment)

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@achingbrain achingbrain requested a review from a team as a code owner March 12, 2024 09:52
Exposes a `.dns` property on the Helia interface for use with other
modules such as @helia/ipns.

Refs: ipfs/helia-verified-fetch#13 (comment)
@achingbrain achingbrain force-pushed the feat/expose-dns-property branch from d0a0864 to 41befc7 Compare March 12, 2024 12:04
achingbrain added a commit that referenced this pull request Mar 12, 2024
Uses the `.dns` property from #465 to resolve DNS `TXT` records.

This allows configuring discrete resolvers for different TLDs, unifies caching across different use of DNS (e.g. dnsaddr multiaddrs), etc.

BREAKING CHANGE: requires @helia/interface@4.1.x or later, `resolveDns` has been renamed `resolveDNSLink`
Copy link
Member

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@achingbrain achingbrain merged commit 8c9bb7d into main Mar 13, 2024
18 checks passed
@achingbrain achingbrain deleted the feat/expose-dns-property branch March 13, 2024 05:27
@achingbrain achingbrain mentioned this pull request Mar 13, 2024
@2color
Copy link
Member

2color commented Mar 13, 2024

Nice!

achingbrain added a commit that referenced this pull request Mar 14, 2024
Uses the `.dns` property from #465 to resolve DNS `TXT` records.

This allows configuring discrete resolvers for different TLDs, unifies caching across different use of DNS (e.g. dnsaddr multiaddrs), etc.

Refs: ipfs/helia-verified-fetch#13 (comment)
Fixes: #369

BREAKING CHANGE: requires @helia/interface@4.1.x or later, `resolveDns` has been renamed `resolveDNSLink`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants