-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Muon-based Brave Browser Integrations #312
Comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Great news, we're working with the Brave team directly, and our goal is to get @whyrusleeping what would be a sensible default config and args for running a go-ipfs daemon as a utility process in a browser; the end user will only use it via ipfs-companion. Something like ipfs daemon --init --migrate=true --enable-gc --routing=dhtclient |
Why |
@mojoaxel maturity, feature set and general performance when run as a background service. At this time go-ipfs is easier on CPU and provides |
There is the lowpower profile, but it might be a bit too aggressive - https://github.com/ipfs/go-ipfs/blob/master/repo/config/profile.go#L153-L158 |
@magik6j @whyrusleeping something like a |
@olizilla yes, please do. We'll try and get that added before the next release. |
Brave announced first release of Chromium-based version. IPFS Companion works perfectly with Chromium-based Brave, and this PR updates our docs to reflect that. I also updated #312 (comment) to provide better intro to currently ongoing work. |
Work related to Chromium-based Brave continues in #716 |
historical notes about Muon-based Brave (early 2018)
ipfs-companion
runs in brave!The following ipfs address styles resolve, either to a local gateway, or the public one.
In the case of
ipfs://
style, brave prompts the user if it's ok to "open in an external application. The url shown is the gateway url rather than what's been entered in the url bar, which could cause confusion.A nice feature of using the
ipfs://
form is that it is preserved in the url bar. The other forms are translated to a gateway url.NURI style isn't supported (just for completeness)
/ipfs/QmZyRCtk8MGpuWXn2d1QyTfLWKMTHrT2aHs2vDkfry5zKT is redirected to
file:///ipfs/QmZyRCtk8MGpuWXn2d1QyTfLWKMTHrT2aHs2vDkfry5zKT
Brave supports a subset of the the chrome-extensions api, so there are few issues to figure out.
Things to get working
Missing apis
We can talk to brave about getting this enabled in muon.
contextMenus.create
(means no ipfs option appears when right clicking on a page)contextMenus.update
idle.queryState
runtime.openOptionsPage
(this causes the Open Preferences fail)Requested, brave/browser-laptop#9556 (comment)
Minor
The text was updated successfully, but these errors were encountered: