Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(brave): Embedded HTTP Gateway for /ipns/{fqdn} with sharding #719

Merged
merged 2 commits into from
May 8, 2019

Conversation

lidel
Copy link
Member

@lidel lidel commented May 8, 2019

Part of an effort to run embedded js-ipfs in Brave 🦁 #716, brave/brave-browser#819 (comment)

tl;dr opening /ipns/tr.wikipedia-on-ipfs.org/wiki/Mars.html works:

working-ipns-dnslink-hamt-2019-05-08--11-21-43

This PR switches to js-ipfs with cherry-picked changes from upstream PRs:

ipfs/js-ipfs#2020, ipfs/js-ipfs#1989, ipfs/js-ipfs#2002, ipfs/js-ipfs-http-response#22, ipfs-inactive/js-ipfs-mfs#48

Known Issues

  • DHT is disabled in js-ipfs so content discovery remains slow unless bootrstrap/preload nodes have the content you want
    • a temporary workaround for testing gateway feature is to run go-ipfs locally with websocket transport enabled and connect Brave instance to it via ipfsCompanion.ipfs.swarm.connect('/ip4/127.0.0.1/tcp/4042/ws/ipfs/{peerId}')
  • Unicode support in URI paths is missing, will be fixed in a separate PR to js-ipfs

tl;dr opening /ipns/tr.wikipedia-on-ipfs.org/wiki/Mars.html works

Switched to js-ipfs with cherry-picked changes from:
ipfs/js-ipfs#2020
ipfs/js-ipfs#1989
ipfs/js-ipfs#2002
ipfs/js-ipfs-http-response#22
ipfs-inactive/js-ipfs-mfs#48
@ghost ghost assigned lidel May 8, 2019
@ghost ghost added the status/in-progress In progress label May 8, 2019
@lidel lidel merged commit 4d935ba into master May 8, 2019
@ghost ghost removed the status/in-progress In progress label May 8, 2019
@lidel lidel deleted the feat/brave-gateway-wiki branch May 8, 2019 10:37
@lidel lidel added the area/brave Issues related to Brave Browser label Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/brave Issues related to Brave Browser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant