Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): automated Snapcraft publishing #1678

Merged
merged 2 commits into from
Oct 8, 2020
Merged

feat(ci): automated Snapcraft publishing #1678

merged 2 commits into from
Oct 8, 2020

Conversation

lidel
Copy link
Member

@lidel lidel commented Oct 7, 2020

This PR aims to remove the need for manually publishing snap to Snapcraft.
Closes #1551

  • The workflow is triggered when a new release is published.
  • It assumes .snap is attached to the release,
    • downloads it
      • and then publishes it to Snapcraft at snapcraft.io/ipfs-desktop

This workflow is triggered when a new release is published.
It assumes `.snap` is attached to the release, downloads it and then
publishes it to Snapcraft at https://snapcraft.io/ipfs-desktop

License: MIT
Signed-off-by: Marcin Rataj <lidel@lidel.org>
@lidel lidel marked this pull request as ready for review October 7, 2020 20:13
License: MIT
Signed-off-by: Marcin Rataj <lidel@lidel.org>
Copy link
Contributor

@jessicaschilling jessicaschilling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to approve on principle - can't provide much context though.

@lidel lidel merged commit f489c82 into master Oct 8, 2020
@lidel lidel deleted the feat/snap-publish branch October 8, 2020 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore snap publishing on snapcraft
2 participants