Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore snap publishing on snapcraft #1551

Closed
bertrandfalguiere opened this issue Jun 15, 2020 · 7 comments · Fixed by #1678
Closed

Restore snap publishing on snapcraft #1551

bertrandfalguiere opened this issue Jun 15, 2020 · 7 comments · Fixed by #1678
Assignees
Labels
effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature need/community-input Needs input from the wider community P2 Medium: Good to have, but can wait until someone steps up status/in-progress In progress topic/package-managers Package managers

Comments

@bertrandfalguiere
Copy link
Contributor

This is a placeholder for me to tackle this.
Snap publishing was removed because of #1547 : it was at the wrong place and it unpolitely interrupted testing.

@bertrandfalguiere bertrandfalguiere added the need/triage Needs initial labeling and prioritization label Jun 15, 2020
@jessicaschilling
Copy link
Contributor

@bertrandfalguiere - do you mind adding the appropriate labels to this issue when you get a chance? You can see details of the labeling system here: https://github.com/ipfs/community/blob/master/ISSUE_LABELS.md
Thanks!

@bertrandfalguiere
Copy link
Contributor Author

I don't mind, but I think I don't have the right for it?

I think this could be
priority/P2
kind/enhancement or king/maintenance
need/community-input
dif/easy
effort/hours
status/in-progress
topic/package-manager

I can be assigned too, but I don't think I have the rights either.

@jessicaschilling jessicaschilling added exp/novice Someone with a little familiarity can pick up effort/hours Estimated to take one or several hours kind/enhancement A net-new feature or improvement to an existing feature need/community-input Needs input from the wider community P2 Medium: Good to have, but can wait until someone steps up status/in-progress In progress topic/package-managers Package managers and removed need/triage Needs initial labeling and prioritization labels Jul 1, 2020
@jessicaschilling
Copy link
Contributor

@bertrandfalguiere, I'm sorry about the permissions! Thanks for that list. I added the labels and assigned you. 😊

@olizilla
Copy link
Member

The lowest friction route here seems to be adopting a snapcraft.yml file into this repo, and letting the snapstore build infra build out the snap files for us, and then promote new releases to the stable channel via the snapstore ui. I love full automation, but the periodic build failure from stale credentials will get annoying.

@lidel
Copy link
Member

lidel commented Jul 15, 2020

We are already publishing generic .tar.xz at well-known URLs:

I believe we could go https://snapcraft.io/docs/pre-built-apps route and reuse prebuilt .tar.xz
That way Snap would be just thin wrapping on top of original artifact built by us.

@bertrandfalguiere
Copy link
Contributor Author

bertrandfalguiere commented Jul 15, 2020

@olizilla slayed the snap dragon for go-ipfs in ipfs/kubo#7250 (comment) 🛡🗡🐉!

Now it's a matter of time to be able to install ipfs-desktop from the default app store of Ubuntu, right?

@lidel
Copy link
Member

lidel commented Aug 4, 2020

@bertrandfalguiere yes, but it's a low priority for the team (limited bandwidth).

If anyone has time to create a PR to try approach from #1551 (comment) I'd be happy to test and review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature need/community-input Needs input from the wider community P2 Medium: Good to have, but can wait until someone steps up status/in-progress In progress topic/package-managers Package managers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants