Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add icons stories #1524

Merged
merged 1 commit into from
Jun 22, 2020
Merged

chore: add icons stories #1524

merged 1 commit into from
Jun 22, 2020

Conversation

rafaelramalho19
Copy link
Contributor

Allows:

  • searching icons by text query
  • changing the fill & stroke color
  • changing the size of the icons

Direct benefits:

  • found out problems with existing icons, like miss-configured viewbox and fill (will fix this in a PR soon)
  • we can preview all the icons we're using 🎉

Showcase: https://dl.dropboxusercontent.com/s/4se8lc2atpo36qf/cBPG7IhgSF.mp4

Copy link
Contributor

@jessicaschilling jessicaschilling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great idea 😊
I added ipfs-shipyard/ipfs-css#42 for the small-arrow color problem.

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ – @rafaelramalho19 feel free to merge :)

@rafaelramalho19 rafaelramalho19 merged commit 20be963 into master Jun 22, 2020
@rafaelramalho19 rafaelramalho19 deleted the chore/add-icons-stories branch June 22, 2020 18:17
pplealf added a commit to pplealf/ipfs-webui that referenced this pull request Dec 20, 2020
pplealf added a commit to pplealf/ipfs-webui that referenced this pull request Dec 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants