test(storybook): add PeerBandwidthTable.stories.js #2095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whizzzkid
approved these changes
Feb 9, 2023
There was a problem hiding this comment.
Why call it a chore?
- https://icon.now.sh/triangleUp or down is not reachable, can we also fix that as part of this?
Not blocking this but that broken icon looks bad.
I guess it's technically a test but wasnt required, isnt a fix, isnt a feat, and not docs.. Im fine with either.
Yea as mentioned in the description, this component doesn't seem to be used, so i think we could address later if the component is used? But i think the component has value either way as an example.. we could add a version of this to the status or peers page later and could address it then. |
Co-authored-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>
Co-authored-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>
Co-authored-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>
SgtPooki
changed the title
ipfs-gui-bot
pushed a commit
that referenced
this pull request
Jul 25, 2023
## [4.1.0](v4.0.2...v4.1.0) (2023-07-25) CID `bafybeieqdeoqkf7xf4aozd524qncgiloh33qgr25lyzrkusbcre4c3fxay` --- ### Features * add 4EVERLAND to list of pinning service providers ([#2107](#2107)) ([12a0f87](12a0f87)) ### Bug Fixes * **ci:** e2e coverage ([#2142](#2142)) ([83353e0](83353e0)) * ipld-explorer-components@4.0.2 ([#2141](#2141)) ([670ba7c](670ba7c)) ### Tests * only repeat e2e tests on PRs ([#2124](#2124)) ([530c501](530c501)) * **storybook:** add PeerBandwidthTable.stories.js ([#2095](#2095)) ([c969c5e](c969c5e)) ### Trivial Changes * Pull transifex translations ([#2137](#2137)) ([2284453](2284453)) * Pull transifex translations ([#2140](#2140)) ([95d468b](95d468b))
|
🎉 This PR is included in version 4.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #2094
adding storybook coverage to file with low coverage at https://app.codecov.io/gh/ipfs/ipfs-webui/tree/main/src/status
@alanshaw @hacdias @lidel @olizilla Do any of you know if this component was ever used? If so, was it removed purposefully?
It looks like this table is supposed to be surfaced inside the currently used peers table as a single column (see screenshot from #1616)
other related issues: