-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ci): e2e coverage #2142
fix(ci): e2e coverage #2142
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
- name: Cache bigger downloads | ||
uses: actions/cache@v3.3.1 | ||
id: cache | ||
with: | ||
path: ${{ github.workspace }}/.cache | ||
key: ${{ runner.os }}-${{ hashFiles('package.json', 'package-lock.json') }} | ||
restore-keys: | | ||
${{ runner.os }}-${{ hashFiles('package.json', 'package-lock.json') }} | ||
${{ runner.os }}- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like a good candidate for reusable workflows
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is already a re-usable workflow :(
## [4.1.0](v4.0.2...v4.1.0) (2023-07-25) CID `bafybeieqdeoqkf7xf4aozd524qncgiloh33qgr25lyzrkusbcre4c3fxay` --- ### Features * add 4EVERLAND to list of pinning service providers ([#2107](#2107)) ([12a0f87](12a0f87)) ### Bug Fixes * **ci:** e2e coverage ([#2142](#2142)) ([83353e0](83353e0)) * ipld-explorer-components@4.0.2 ([#2141](#2141)) ([670ba7c](670ba7c)) ### Tests * only repeat e2e tests on PRs ([#2124](#2124)) ([530c501](530c501)) * **storybook:** add PeerBandwidthTable.stories.js ([#2095](#2095)) ([c969c5e](c969c5e)) ### Trivial Changes * Pull transifex translations ([#2137](#2137)) ([2284453](2284453)) * Pull transifex translations ([#2140](#2140)) ([95d468b](95d468b))
🎉 This PR is included in version 4.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
e2e tests were failing due to sharding and lack of coverage found in some shards: https://github.com/ipfs/ipfs-webui/actions/runs/5650403570
This PR fixes that. It also batches some actions that should be batched.
which should result in the e2e tests being faster overall.
Successful run on SgtPooki/ipfs-webui: https://github.com/SgtPooki/ipfs-webui/actions/runs/5651849593