chore: update libp2p@0.31 #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
commented
Apr 30, 2021
| @@ -648,6 +648,7 @@ describe('Engine', () => { | |||
|
|
|||
| const onlyCases = [] | |||
| for (const testCase of testCases) { | |||
| // eslint-disable-next-line | |||
There was a problem hiding this comment.
This skips error link with testCase.only not permitted [Error/no-only-tests/no-only-tests]
If I try to specify the actual error in the comment I get linting to shout that Definition for rule 'no-only-tests' was not found. [Error/no-only-tests] 🤷🏼
There was a problem hiding this comment.
We love to keep things interesting 🙄
achingbrain
approved these changes
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs: