Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: moving averages record types #935

Merged
merged 1 commit into from
Apr 30, 2021

Conversation

vasco-santos
Copy link
Member

@vasco-santos vasco-santos commented Apr 30, 2021

Before the data type of Moving Averages (IMovingAverage) was exported by default, while the module exported the function that creates the IMovingAverage by default. This was creating issues on lodestar and we fixed it, but now libp2p record needs to store IMovingAverage instead

@vasco-santos vasco-santos merged commit b5a9eb2 into master Apr 30, 2021
@vasco-santos vasco-santos deleted the fix/moving-averages-record-types branch April 30, 2021 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants