Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

jsipfs files cat $HASH shows no output #476

Closed
victorb opened this issue Sep 10, 2016 · 4 comments
Closed

jsipfs files cat $HASH shows no output #476

victorb opened this issue Sep 10, 2016 · 4 comments
Assignees
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@victorb
Copy link
Member

victorb commented Sep 10, 2016

To reproduce, run the following in js-ipfs repository

$ HASH=$(node src/cli/bin.js files add package.json | cut -f2 -d ' ')
$ node src/cli/bin.js files cat $HASH

No output, but should show the contents of package.json

I'll take a look and if I can figure out why and fix it.

@victorb victorb added the kind/bug A bug in existing code (including security flaws) label Sep 10, 2016
@victorb victorb self-assigned this Sep 10, 2016
victorb added a commit that referenced this issue Sep 10, 2016
Add tests for making sure .cat shows right output and fix that test by
using the right argument from cli. Ref: issue #476
@victorb
Copy link
Member Author

victorb commented Sep 10, 2016

Still missing, seems like sub-files from a hash not working correctly either.

Example:

node src/cli/bin.js files cat /ipfs/QmegvLXxpVKiZ4b57Xs1syfBVRd8CbucVHAp7KpLQdGieC/readme

Shows no output atm.

victorb added a commit that referenced this issue Sep 10, 2016
Add tests for making sure .cat shows right output and fix that test by
using the right argument from cli. Ref: issue #476
@daviddias
Copy link
Member

@victorbjelkholm correct, that is a feature that isn't currently supported, although there is no technical reason why not to, all the pieces are there :)

@victorb
Copy link
Member Author

victorb commented Sep 12, 2016

@diasdavid I'll add a new PR for that

@victorb victorb mentioned this issue Sep 12, 2016
daviddias pushed a commit that referenced this issue Sep 12, 2016
Add tests for making sure .cat shows right output and fix that test by
using the right argument from cli. Ref: issue #476
@daviddias daviddias self-assigned this Sep 12, 2016
@dignifiedquire
Copy link
Member

Fixed in #477

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Development

No branches or pull requests

3 participants