This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
fix(cli): use right argument for cli .cat #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -9,14 +9,15 @@ const _ = require('lodash') | |||
|
|
|||
| describe('files', () => { | |||
| const env = _.clone(process.env) | |||
| env.IPFS_PATH = repoPath | |||
| process.env.IPFS_PATH = repoPath | |||
There was a problem hiding this comment.
This should not be modified. As env is passed in below into the command and this would modify the whole process.
There was a problem hiding this comment.
You're absolutely right, silly me. Fixed!
Add tests for making sure .cat shows right output and fix that test by using the right argument from cli. Ref: issue #476
victorb
force-pushed
the
issue-476-no-cat-output
branch
from
94791b8
to
dd3fe88
Compare
daviddias
added
status/in-progress
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for making sure .cat shows right output and fix that test by
using the right argument from cli. Ref: issue #476