Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nicer looking index page #1153

Closed
jbenet opened this issue Apr 28, 2015 · 17 comments · Fixed by #1406
Closed

nicer looking index page #1153

jbenet opened this issue Apr 28, 2015 · 17 comments · Fixed by #1406
Assignees

Comments

@jbenet
Copy link
Member

jbenet commented Apr 28, 2015

this is not so hot:

would be nice to have humanized sizes. and nice listings. and maybe have links to ipfs.

@whyrusleeping
Copy link
Member

should be as simple as deciding what we want: https://github.com/ipfs/go-ipfs/blob/master/core/corehttp/gateway_handler.go#L491

@whyrusleeping whyrusleeping mentioned this issue May 11, 2015
30 tasks
@jbenet jbenet mentioned this issue May 19, 2015
52 tasks
@krl
Copy link
Contributor

krl commented May 20, 2015

@krl
Copy link
Contributor

krl commented May 20, 2015

using MIT licensed https://github.com/teambox/Free-file-icons

@krl krl self-assigned this May 20, 2015
@whyrusleeping
Copy link
Member

krl thats a lot nicer :)

@jbenet
Copy link
Member Author

jbenet commented May 20, 2015

Very nice! Would be nice to include an ipfs logo or something. like "served by IPFS".

also-- this is perhaps a separate PR -- we should do something cool with the index page. index pages haven't changed much in decades-- what could we do? previews? allow switching between "list, thumbnail, gallery" view? (insta-media-galleries)

(more ideas!)

@jbenet
Copy link
Member Author

jbenet commented May 20, 2015

@jbenet
Copy link
Member Author

jbenet commented May 20, 2015

Idea: make the index page optionally take an argument, as a "viewer" which is JS that is loaded and runs on the page.

this could potentially be super dangerous, but it's an interesting idea.

@krl
Copy link
Contributor

krl commented May 21, 2015

+1 more branding
+1 gallery mode

@jbenet: would be nice to spec out what a viewer would be, and how it could potentially support non-unixfs structures as well.

@whyrusleeping
Copy link
Member

would it be ipfs.io/ipfs/viewer#path or ipfs.io/ipfs/path#viewer ?

@jbenet
Copy link
Member Author

jbenet commented May 21, 2015

the problem with using the #<path> notation is that it breaks anchors :(

On Wed, May 20, 2015 at 11:46 PM, Jeromy Johnson notifications@github.com
wrote:

would it be ipfs.io/ipfs/viewer#path or ipfs.io/ipfs/path#viewer ?


Reply to this email directly or view it on GitHub
#1153 (comment).

@whyrusleeping whyrusleeping mentioned this issue May 26, 2015
49 tasks
@whyrusleeping whyrusleeping mentioned this issue Jun 2, 2015
58 tasks
@krl
Copy link
Contributor

krl commented Jun 5, 2015

http://gateway.ipfs.io/ipfs/QmTxNTmUDXBPvyjg4bAo5Qizs6ag1sXtZkfhNxv7yE7AzC/filelist.html

here's a more branded version. @jbenet, @cryptix - how do we best get this into go-ipfs?

@cryptix
Copy link
Contributor

cryptix commented Jun 5, 2015

@krl that looks awesome! We currently hardcode the html template for the index here.

@jbenet
Copy link
Member Author

jbenet commented Jun 5, 2015

@krl looks very good. can we put that thing in a repo somewhere, and have the go templating in a pkg there? (i'd like to use it in other tools, and i'd like to give feedback on it)

@cryptix
Copy link
Contributor

cryptix commented Jun 5, 2015

can we put that thing in a repo somewhere, and have the go templating in a pkg there?

Do our unixfs objects implement os.File? Otherwise I'm not sure how much reuse you will get out of this.

@jbenet
Copy link
Member Author

jbenet commented Jun 5, 2015

@cryptix not that-- the templating from names, icons, sizes -> nice output.

@krl
Copy link
Contributor

krl commented Jun 9, 2015

@whyrusleeping whyrusleeping mentioned this issue Jun 9, 2015
50 tasks
@jbenet
Copy link
Member Author

jbenet commented Jun 9, 2015

@krl thanks

@cryptix cryptix mentioned this issue Jun 20, 2015
5 tasks
@jbenet jbenet assigned cryptix and unassigned krl Jun 20, 2015
@jbenet jbenet added status/in-progress In progress and removed sprint labels Jun 20, 2015
@jbenet jbenet removed the status/in-progress In progress label Jul 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants