Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nicer index #1406

Merged
merged 4 commits into from
Jul 4, 2015
Merged

Nicer index #1406

merged 4 commits into from
Jul 4, 2015

Conversation

cryptix
Copy link
Contributor

@cryptix cryptix commented Jun 20, 2015

This introduces @krl's new index page

TODO:

@GitCop
Copy link

GitCop commented Jun 20, 2015

There were the following issues with your Pull Request

  • Commit: 0ad606f
    • Invalid signoff. Commit message must end with License: MIT
      Signed-off-by: .* <.*>

Guidelines are available to help. Your feedback on GitCop is welcome on this issue

This message was auto-generated by https://gitcop.com

@jbenet jbenet added the status/in-progress In progress label Jun 20, 2015
@cryptix
Copy link
Contributor Author

cryptix commented Jun 20, 2015

squashed to one commit with signed-off-by

cryptix
cryptix reviewed Jun 20, 2015
View reviewed changes
core/corehttp/gateway_indexPage.go
return "ipfs-" + ext[1:] // slice of the first dot
}

var knownIcons = map[string]bool{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure there is a nicer way to do this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go generate too maybe?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are the icons coming from a font?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should use font-awesome here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh you already put them all in the css 👍 wfm.

@jbenet
Copy link
Member

jbenet commented Jun 20, 2015

where to we seed the assets?

add them to https://github.com/ipfs/infrastructure/blob/master/seeding/refs-to-seed + get me to pin them.

add tests. Do we have known/mocked hashes to test this a little? Basically I just want to test 404 and rendering without errors.

not really, can make some though in a test case

For testing the HTML we could use goquery

probably fine without

@GitCop
Copy link

GitCop commented Jun 21, 2015

There were the following issues with your Pull Request

  • Commit: d9febfa
    • Invalid signoff. Commit message must end with License: MIT
      Signed-off-by: .* <.*>

Guidelines are available to help. Your feedback on GitCop is welcome on this issue

This message was auto-generated by https://gitcop.com

@cryptix
Copy link
Contributor Author

cryptix commented Jun 22, 2015

RFM ping @jbenet

@whyrusleeping
Copy link
Member

I really feel like the template should have zero external dependencies. Any css and javascript should be embedded IMO. If i dont have internet, all of a sudden my gateway wont work.

@cryptix
Copy link
Contributor Author

cryptix commented Jun 22, 2015

If i dont have internet, all of a sudden my gateway wont work.

Yea... that's correct

Are the welcome examples seeded from the net or automagically added during init?
If we don't have something like that, i can inline them, too.

@whyrusleeping
Copy link
Member

the welcome examples are seeded during init, i guess you could add them like that too if you want.

@cryptix
Copy link
Contributor Author

cryptix commented Jun 22, 2015

I don't mind either way (or even adding new handlers) just don't want to waste effort.

cc @jbenet: what do you prefer?

@jbenet jbenet mentioned this pull request Jun 22, 2015
Closed
55 tasks
@jbenet
Copy link
Member

jbenet commented Jun 23, 2015

the welcome examples are seeded during init, i guess you could add them like that too if you want.

this is the preferred approach. put all the files in the same root dir and pin that.

@whyrusleeping whyrusleeping mentioned this pull request Jun 23, 2015
Closed
34 tasks
@jbenet
Copy link
Member

jbenet commented Jun 30, 2015

@cryptix update?

@cryptix
Copy link
Contributor Author

cryptix commented Jul 1, 2015

@jbenet waiting for #1419 (or rolling back to doc2go and embedding the css by hand)

@whyrusleeping whyrusleeping mentioned this pull request Jul 1, 2015
Closed
44 tasks
@cryptix
http/gateway:
0ed49db 
- First tab at integrating @krl's new index page

File icons are embedded in side icons.css (QmXB7PLRWH6bCiwrGh2MrBBjNkLv3mY3JdYXCikYZSwLED contains both the icons and bootstrap)

- Fix back links (..)  (fixes #1365)

Thanks @JasonWoof for the insight.  The back links now stop a t the root hash and work for links that do and dont end with a slash.

License: MIT
Signed-off-by: Henry <cryptix@riseup.net>
@cryptix
http/index: fix indention and remove unused field
053e531 
License: MIT
Signed-off-by: Henry <cryptix@riseup.net>
@cryptix
sharness/t0110-gateway: add simple 404 check for non existent file
358d04c 
License: MIT
Signed-off-by: Henry <cryptix@riseup.net>
@cryptix
Copy link
Contributor Author

cryptix commented Jul 3, 2015

Assets are now seeded during (daemon) init. Also rebased for fun > ??? > profit ;)

@cryptix
assets: seed gateway index assets on 'ipfs init'
1b16712 
License: MIT
Signed-off-by: Henry <cryptix@riseup.net>

t0080-repo.sh: added gateway assets to pinning tests

License: MIT
Signed-off-by: Henry <cryptix@riseup.net>
jbenet added a commit that referenced this pull request Jul 4, 2015
@jbenet
Merge pull request #1406 from ipfs/nicerIndex
224a9eb 
Nicer index
@jbenet jbenet merged commit 224a9eb into master Jul 4, 2015
@jbenet jbenet removed the status/in-progress In progress label Jul 4, 2015
@jbenet jbenet deleted the nicerIndex branch July 4, 2015 01:28
hacdias pushed a commit to ipfs/boxo that referenced this pull request Jan 27, 2023
@jbenet
Merge pull request ipfs/kubo#1406 from ipfs/nicerIndex
914a03c 
Nicer index

This commit was moved from ipfs/kubo@224a9eb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.. links in http proxy borked unless url ends with a slash nicer looking index page
4 participants
@cryptix @GitCop @jbenet @whyrusleeping