Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for Ed25519 public key IPFS identities #3896

Closed
9 of 14 tasks
JustinDrake opened this issue May 2, 2017 · 4 comments
Closed
9 of 14 tasks

Changes for Ed25519 public key IPFS identities #3896

JustinDrake opened this issue May 2, 2017 · 4 comments

Comments

@JustinDrake
Copy link
Contributor

JustinDrake commented May 2, 2017

Below are the changes to support Ed25519 public key identity types. It was taken from ipfs/notes#241 incorporating comments from @whyrusleeping and @Kubuxu.

@jbenet
Copy link
Member

jbenet commented May 4, 2017

I made the allocations above ^ lmk if that makes sense or not, or edit as makes sense.

@JustinDrake
Copy link
Contributor Author

I've added two more PRs for review libp2p/go-libp2p-crypto#24, libp2p/go-libp2p-peer#13 👍

@JustinDrake
Copy link
Contributor Author

@whyrusleeping: In regards to the task to generalise IDFromPublicKey assigned to you, I have written a function IDFromEd25519PublicKey in libp2p/go-libp2p-peer#14 (used for tests) 👍

JustinDrake added a commit to JustinDrake/go-ipfs that referenced this issue Jun 21, 2017
Initial implementation for ipfs#3896

The function `peer.ExtractPublicKey()` is part of PR libp2p/go-libp2p-peer#14

cc @whyrusleeping
JustinDrake added a commit to JustinDrake/go-ipfs that referenced this issue Jun 21, 2017
Initial implementation for ipfs#3896

The function `peer.ExtractPublicKey()` is part of PR libp2p/go-libp2p-peer#14

cc @whyrusleeping
JustinDrake added a commit to JustinDrake/multicodec that referenced this issue Jun 21, 2017
JustinDrake added a commit to JustinDrake/go-ipfs that referenced this issue Jun 28, 2017
See ipfs#3998

Initial implementation for ipfs#3896

The function `peer.ExtractPublicKey()` is part of PR libp2p/go-libp2p-peer#14

cc @whyrusleeping

License: MIT
Signed-off-by: Justin Drake <drakefjustin@gmail.com>
xlab added a commit to AtlantPlatform/go-ipfs that referenced this issue Apr 22, 2018
@lidel
Copy link
Member

lidel commented Feb 11, 2022

In 2022, ed25519 keys are the default in both go-ipfs and js-ipfs ✨

@lidel lidel closed this as completed Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants