Add ed25519 public key codec #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See ipfs/notes#241 (comment) I suggest using the code `0xed` so that's it's visually obvious and easy to remember it's associated with ed25519.
|
I'm a little bit confused as to whether or not this is a valid varint codec. |
|
@JustinDrake values in this table are not varint encoded. Varint encoded values might look different. |
|
@Kubuxu I see. Then maybe |
|
I am ok with it being 2bytes. It is just one byte extra and it is not used for content addressing that frequently (1 byte in case of sha would make a difference). @whyrusleeping second opinion. |
Kubuxu
reviewed
Apr 24, 2017
table.csv
Outdated
| @@ -200,3 +200,4 @@ stellar-tx, Stellar Tx, 0xd1 | |||
|
|
|||
| torrent-info, Torrent file info field (bencoded), 0x7b | |||
| torrent-file, Torrent file (bencoded), 0x7c | |||
| ed25519, Ed25519 public key, 0xed | |||
There was a problem hiding this comment.
I would change the name to ed25519-pub.
JustinDrake
added a commit
to JustinDrake/go-multicodec-packed
that referenced
this pull request
May 5, 2017
This was referenced May 5, 2017
Kubuxu
approved these changes
May 5, 2017
|
I think this LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See ipfs/notes#241 (comment)
I suggest using the code
0xedso that's it's visually obvious and easy to remember it's associated with ed25519.