Run tests with race flag #1013
Run tests with race flag #1013
Conversation
This makes it possible to build binaries with different flags. The content of the GOFLAGS variable is stored in a IPFS-BUILD-OPTIONS file, so that if GOFLAGS changes a rebuild of the binaries with the new flags is forced. License: MIT Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
This builds go binaries using the -race flag and then runs all the tests. License: MIT Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
...and remove bin/* stuff from the .gitignore as /test/bin is already in the root .gitignore. License: MIT Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
The GOFLAGS variable makes it possible to run all sharness tests with go binaries built with some special flags. The "race" target makes it easy run the sharness tests with go binaries built with the -race flag. License: MIT Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
| if test x"$$VARS" != x"`cat $@ 2>/dev/null`" ; then \ | ||
| echo "*** new Go flags ***"; \ | ||
| echo "$$VARS" >$@; \ | ||
| fi |
There was a problem hiding this comment.
this seems very magic-y to me. wonder if maybe the right thing to do is to have both:
bin/program
bin/program-race
that way we could even have concurrent tests going
There was a problem hiding this comment.
I copied what is done in the Git Makefile for these kind of things.
It is just checking if the content of the GOFLAGS variable is different from what is in the IPFS-BUILD-OPTIONS file, and if it is different, it puts the content of the GOFLAGS variable into the file.
We could have something like:
bin/program-normal
bin/program-race
and then a bin/program symlink that points to one or the other of the above binaries. But I am not sure it would be simpler and this way we couldn't have concurent tests going on.
To have concurent tests going on, we would need to modify the test scripts before launching them with something like sed 's/ipfs/ipfs-race/g' but it could be tricky to get right too.
Or maybe I am missing something?
|
Note that I used this patch series to check if there are race conditions in all the sharness tests, and I found some only in t0090-get.sh (see issue #1012). |
|
Closing this as the alternative PR #1024 is merged. |
This should make it easier to find race conditions like issue #1012.