Run tests with race flag using checkflags script #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This script can be used in a Makefile to detect flag changes and to save the new flags in a file. License: MIT Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
This makes it possible to build binaries with different flags. The content of the GOFLAGS variable is stored in a IPFS-BUILD-OPTIONS file, so that if GOFLAGS changes a rebuild of the binaries with the new flags is forced. License: MIT Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
This builds go binaries using the -race flag and then runs all the tests. License: MIT Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
...and remove bin/* stuff from the .gitignore as /test/bin is already in the root .gitignore. License: MIT Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
The GOFLAGS variable makes it possible to run all sharness tests with go binaries built with some special flags. The "race" target makes it easy run the sharness tests with go binaries built with the -race flag. License: MIT Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
|
I think this LGTM, but can @whyrusleeping and @cryptix to take a look too. also @chriscool did you see comment about building to another dir? say have parallel bins at both: ? dont have to go this route (may be more annoying) but figured it was worth considering. |
ah missed that thanks
yeah, it wont :) let's go with your approach. |
|
I think this works great, thanks @chriscool |
jbenet
added a commit
that referenced
this pull request
Apr 7, 2015
Run tests with race flag using checkflags script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative implementation of PR #1013 (Run tests with race flag) using a "checkflags" script.
As for PR #1013 the goal is to make it easier to find race conditions like issue #1012.