fix: graceful shutdown and interrupt handling #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidel
force-pushed
the
fix/graceful-shutdown
branch
from
7ce881c
to
58c0309
Compare
lidel
force-pushed
the
fix/graceful-shutdown
branch
from
58c0309
to
41421f9
Compare
5 tasks
|
Landing to fix regression from #72, we can refine later. |
lidel
force-pushed
the
fix/graceful-shutdown
branch
from
41421f9
to
9ddf763
Compare
This fixes interrupt handling when ^C is hit in terminal and improves UX in general
lidel
force-pushed
the
fix/graceful-shutdown
branch
from
9ddf763
to
c17ea41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix interrupt handling when ^C is hit in terminal (a regression detected in #72, so PR against that).
It was not possible to stop
./someguy startvia regular interrupt, so I've ported interrupt signal handling from rainbow.Graceful shutdown should help us avoid caching truncated streaming responses.
Tested with
abtool, works as expected.