Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release v0.3.0 #76

Merged
merged 1 commit into from
Jun 25, 2024
Merged

chore: release v0.3.0 #76

merged 1 commit into from
Jun 25, 2024

Conversation

lidel
Copy link
Member

@lidel lidel commented Jun 24, 2024

@lidel
Copy link
Member Author

lidel commented Jun 24, 2024

Seems that goreleaser CI job checks failed due to Github API quota, and it is probably also why we had panic in comment above:

RequestError [HttpError]: You have exceeded a secondary rate limit. Please wait a few minutes before you try again. If you reach out to GitHub Support for help, please include the request ID  [..]

I'll retry later today / tomorrow, and if not resolved, ping IPDX for help.

@lidel
Copy link
Member Author

lidel commented Jun 25, 2024

cc @ipfs/ipdx for visibility: I imagine the panic in the gorelease above is due to github API limits error and missing error handling. My plan is to re-run in a few hours, but lmk if this looks familiar or is something else.

The comment created by releaser job (yml) was (i had to remove it so its generated on re-run):

gorelease says:

panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x5e692f]

goroutine 419 [running]:
go/types.(*Checker).handleBailout(0xc0003e4000, 0xc000809c10)
	/opt/hostedtoolcache/go/1.22.4/x64/src/go/types/check.go:367 +0x88
panic({0x6a6200?, 0x8e0520?})
	/opt/hostedtoolcache/go/1.22.4/x64/src/runtime/panic.go:770 +0x132
go/types.(*StdSizes).Sizeof(0x0, {0x757fb0, 0x8e3980})
	/opt/hostedtoolcache/go/1.22.4/x64/src/go/types/sizes.go:228 +0x30f
go/types.(*Config).sizeof(...)
	/opt/hostedtoolcache/go/1.22.4/x64/src/go/types/sizes.go:333
go/types.representableConst.func1({0x757fb0?, 0x8e3980?})
	/opt/hostedtoolcache/go/1.22.4/x64/src/go/types/const.go:76 +0x9e
go/types.representableConst({0x759db8, 0x8d8c40}, 0xc0003e4000, 0x8e3980, 0xc000808028)
	/opt/hostedtoolcache/go/1.22.4/x64/src/go/types/const.go:92 +0x192
go/types.(*Checker).representation(0xc0003e4000, 0xc00029f040, 0x8e3980)
	/opt/hostedtoolcache/go/1.22.4/x64/src/go/types/const.go:256 +0x65
go/types.(*Checker).implicitTypeAndValue(0xc0003e4000, 0xc00029f040, {0x757fb0, 0x8e3980})
	/opt/hostedtoolcache/go/1.22.4/x64/src/go/types/expr.go:375 +0x2d7
go/types.(*Checker).convertUntyped(0xc0003e4000, 0xc00029f040, {0x757fb0, 0x8e3980})
	/opt/hostedtoolcache/go/1.22.4/x64/src/go/types/const.go:289 +0x3f
go/types.(*Checker).matchTypes(0xc0003e4000, 0xc00029f000, 0xc00029f040)
	/opt/hostedtoolcache/go/1.22.4/x64/src/go/types/expr.go:926 +0x79
go/types.(*Checker).binary(0xc0003e4000, 0xc00029f000, {0x759368, 0xc00037a750}, {0x758f78, 0xc00029cb00}, {0x759878, 0xc00029cb20}, 0x28, 0x363a4)
	/opt/hostedtoolcache/go/1.22.4/x64/src/go/types/expr.go:800 +0x166
go/types.(*Checker).exprInternal(0xc0003e4000, 0x0, 0xc00029f000, {0x759368, 0xc00037a750}, {0x0, 0x0})
	/opt/hostedtoolcache/go/1.22.4/x64/src/go/types/expr.go:1416 +0x206
go/types.(*Checker).rawExpr(0xc0003e4000, 0x0, 0xc00029f000, {0x759368?, 0xc00037a750?}, {0x0?, 0x0?}, 0x0)
	/opt/hostedtoolcache/go/1.22.4/x64/src/go/types/expr.go:979 +0x19e
go/types.(*Checker).expr(0xc0003e4000, 0x7588e8?, 0xc00029f000, {0x759368?, 0xc00037a750?})
	/opt/hostedtoolcache/go/1.22.4/x64/src/go/types/expr.go:1513 +0x30
go/types.(*Checker).stmt(0xc0003e4000, 0x0, {0x759518, 0xc00029e240})
	/opt/hostedtoolcache/go/1.22.4/x64/src/go/types/stmt.go:570 +0x11f2
go/types.(*Checker).stmtList(0xc0003e4000, 0x0, {0xc00029cce0?, 0x0?, 0x0?})
	/opt/hostedtoolcache/go/1.22.4/x64/src/go/types/stmt.go:121 +0x85
go/types.(*Checker).funcBody(0xc0003e4000, 0x757fb0?, {0xc00024a228?, 0x8e3b60?}, 0xc00029ed40, 0xc00037a7e0, {0x0?, 0x0?})
	/opt/hostedtoolcache/go/1.22.4/x64/src/go/types/stmt.go:41 +0x331
go/types.(*Checker).funcDecl.func1()
	/opt/hostedtoolcache/go/1.22.4/x64/src/go/types/decl.go:852 +0x3a
go/types.(*Checker).processDelayed(0xc0003e4000, 0x0)
	/opt/hostedtoolcache/go/1.22.4/x64/src/go/types/check.go:467 +0x162
go/types.(*Checker).checkFiles(0xc0003e4000, {0xc000310040, 0x1, 0x1})
	/opt/hostedtoolcache/go/1.22.4/x64/src/go/types/check.go:411 +0x1cc
go/types.(*Checker).Files(...)
	/opt/hostedtoolcache/go/1.22.4/x64/src/go/types/check.go:372
golang.org/x/tools/go/packages.(*loader).loadPackage(0xc0002b60e0, 0xc0006ce1b0)
	/home/runner/go/pkg/mod/golang.org/x/tools@v0.2.0/go/packages/packages.go:1037 +0x932
golang.org/x/tools/go/packages.(*loader).loadRecursive.func1()
	/home/runner/go/pkg/mod/golang.org/x/tools@v0.2.0/go/packages/packages.go:847 +0x1a9
sync.(*Once).doSlow(0x3234323336313232?, 0x636138393862352d?)
	/opt/hostedtoolcache/go/1.22.4/x64/src/sync/once.go:74 +0xc2
sync.(*Once).Do(...)
	/opt/hostedtoolcache/go/1.22.4/x64/src/sync/once.go:65
golang.org/x/tools/go/packages.(*loader).loadRecursive(0x676e697065656c73?, 0x7379656b2d6f672f?)
	/home/runner/go/pkg/mod/golang.org/x/tools@v0.2.0/go/packages/packages.go:835 +0x4a
golang.org/x/tools/go/packages.(*loader).loadRecursive.func1.1(0x654422090a2c2265?)
	/home/runner/go/pkg/mod/golang.org/x/tools@v0.2.0/go/packages/packages.go:842 +0x26
created by golang.org/x/tools/go/packages.(*loader).loadRecursive.func1 in goroutine 390
	/home/runner/go/pkg/mod/golang.org/x/tools@v0.2.0/go/packages/packages.go:841 +0x94

@ipfs ipfs deleted a comment from github-actions bot Jun 25, 2024
Copy link

Suggested version: v0.3.0

Comparing to: v0.2.3 (diff)

Changes in go.mod file(s):

diff --git a/go.mod b/go.mod
index 67b44d2..85c7ac9 100644
--- a/go.mod
+++ b/go.mod
@@ -1,27 +1,30 @@
 module github.com/ipfs/someguy
 
-go 1.21
+go 1.22
+
+toolchain go1.22.4
 
 require (
 	github.com/CAFxX/httpcompression v0.0.9
+	github.com/coreos/go-systemd/v22 v22.5.0
 	github.com/dustin/go-humanize v1.0.1
 	github.com/felixge/httpsnoop v1.0.4
-	github.com/ipfs/boxo v0.19.1-0.20240515083429-ac0bab3926a8
+	github.com/ipfs/boxo v0.21.0
 	github.com/ipfs/go-cid v0.4.1
 	github.com/ipfs/go-log/v2 v2.5.1
-	github.com/libp2p/go-libp2p v0.33.2
+	github.com/libp2p/go-libp2p v0.35.1
 	github.com/libp2p/go-libp2p-kad-dht v0.25.2
 	github.com/libp2p/go-libp2p-record v0.2.0
-	github.com/multiformats/go-multiaddr v0.12.3
+	github.com/multiformats/go-multiaddr v0.12.4
 	github.com/multiformats/go-multibase v0.2.0
 	github.com/multiformats/go-multihash v0.2.3
 	github.com/pbnjay/memory v0.0.0-20210728143218-7b4eea64cf58
-	github.com/prometheus/client_golang v1.19.0
-	github.com/rs/cors v1.10.1
-	github.com/slok/go-http-metrics v0.11.0
+	github.com/prometheus/client_golang v1.19.1
+	github.com/rs/cors v1.11.0
+	github.com/slok/go-http-metrics v0.12.0
 	github.com/stretchr/testify v1.9.0
-	github.com/urfave/cli/v2 v2.27.1
-	golang.org/x/sys v0.19.0
+	github.com/urfave/cli/v2 v2.27.2
+	golang.org/x/sys v0.21.0
 )
 
 require (
@@ -31,7 +34,6 @@ require (
 	github.com/beorn7/perks v1.0.1 // indirect
 	github.com/cespare/xxhash/v2 v2.3.0 // indirect
 	github.com/containerd/cgroups v1.1.0 // indirect
-	github.com/coreos/go-systemd/v22 v22.5.0 // indirect
 	github.com/cpuguy83/go-md2man/v2 v2.0.4 // indirect
 	github.com/davecgh/go-spew v1.1.1 // indirect
 	github.com/davidlazar/go-crypto v0.0.0-20200604182044-b73af7476f6c // indirect
@@ -40,16 +42,16 @@ require (
 	github.com/elastic/gosigar v0.14.3 // indirect
 	github.com/flynn/noise v1.1.0 // indirect
 	github.com/francoispqt/gojay v1.2.13 // indirect
-	github.com/go-logr/logr v1.4.1 // indirect
+	github.com/go-logr/logr v1.4.2 // indirect
 	github.com/go-logr/stdr v1.2.2 // indirect
-	github.com/go-task/slim-sprig v0.0.0-20230315185526-52ccab3ef572 // indirect
+	github.com/go-task/slim-sprig/v3 v3.0.0 // indirect
 	github.com/godbus/dbus/v5 v5.1.0 // indirect
 	github.com/gogo/protobuf v1.3.2 // indirect
 	github.com/google/gopacket v1.1.19 // indirect
-	github.com/google/pprof v0.0.0-20240409012703-83162a5b38cd // indirect
+	github.com/google/pprof v0.0.0-20240618054019-d3b898a103f8 // indirect
 	github.com/google/uuid v1.6.0 // indirect
 	github.com/gorilla/mux v1.8.1 // indirect
-	github.com/gorilla/websocket v1.5.1 // indirect
+	github.com/gorilla/websocket v1.5.3 // indirect
 	github.com/hashicorp/errwrap v1.1.0 // indirect
 	github.com/hashicorp/go-multierror v1.1.1 // indirect
 	github.com/hashicorp/golang-lru v1.0.2 // indirect
@@ -60,8 +62,8 @@ require (
 	github.com/jackpal/go-nat-pmp v1.0.2 // indirect
 	github.com/jbenet/go-temp-err-catcher v0.1.0 // indirect
 	github.com/jbenet/goprocess v0.1.4 // indirect
-	github.com/klauspost/compress v1.17.8 // indirect
-	github.com/klauspost/cpuid/v2 v2.2.7 // indirect
+	github.com/klauspost/compress v1.17.9 // indirect
+	github.com/klauspost/cpuid/v2 v2.2.8 // indirect
 	github.com/koron/go-ssdp v0.0.4 // indirect
 	github.com/libp2p/go-buffer-pool v0.1.0 // indirect
 	github.com/libp2p/go-cidranger v1.1.0 // indirect
@@ -77,7 +79,7 @@ require (
 	github.com/libp2p/go-yamux/v4 v4.0.1 // indirect
 	github.com/marten-seemann/tcp v0.0.0-20210406111302-dfbc87cc63fd // indirect
 	github.com/mattn/go-isatty v0.0.20 // indirect
-	github.com/miekg/dns v1.1.58 // indirect
+	github.com/miekg/dns v1.1.61 // indirect
 	github.com/mikioh/tcpinfo v0.0.0-20190314235526-30a79bb1804b // indirect
 	github.com/mikioh/tcpopt v0.0.0-20190314235656-172688c1accc // indirect
 	github.com/minio/sha256-simd v1.0.1 // indirect
@@ -89,43 +91,59 @@ require (
 	github.com/multiformats/go-multicodec v0.9.0 // indirect
 	github.com/multiformats/go-multistream v0.5.0 // indirect
 	github.com/multiformats/go-varint v0.0.7 // indirect
-	github.com/onsi/ginkgo/v2 v2.17.1 // indirect
+	github.com/onsi/ginkgo/v2 v2.19.0 // indirect
 	github.com/opencontainers/runtime-spec v1.2.0 // indirect
 	github.com/opentracing/opentracing-go v1.2.0 // indirect
+	github.com/pion/datachannel v1.5.6 // indirect
+	github.com/pion/dtls/v2 v2.2.11 // indirect
+	github.com/pion/ice/v2 v2.3.25 // indirect
+	github.com/pion/interceptor v0.1.29 // indirect
+	github.com/pion/logging v0.2.2 // indirect
+	github.com/pion/mdns v0.0.12 // indirect
+	github.com/pion/randutil v0.1.0 // indirect
+	github.com/pion/rtcp v1.2.14 // indirect
+	github.com/pion/rtp v1.8.6 // indirect
+	github.com/pion/sctp v1.8.16 // indirect
+	github.com/pion/sdp/v3 v3.0.9 // indirect
+	github.com/pion/srtp/v2 v2.0.18 // indirect
+	github.com/pion/stun v0.6.1 // indirect
+	github.com/pion/transport/v2 v2.2.5 // indirect
+	github.com/pion/turn/v2 v2.1.6 // indirect
+	github.com/pion/webrtc/v3 v3.2.42 // indirect
 	github.com/pkg/errors v0.9.1 // indirect
 	github.com/pmezard/go-difflib v1.0.0 // indirect
 	github.com/polydawn/refmt v0.89.0 // indirect
 	github.com/prometheus/client_model v0.6.1 // indirect
-	github.com/prometheus/common v0.52.3 // indirect
-	github.com/prometheus/procfs v0.13.0 // indirect
+	github.com/prometheus/common v0.54.0 // indirect
+	github.com/prometheus/procfs v0.15.1 // indirect
 	github.com/quic-go/qpack v0.4.0 // indirect
-	github.com/quic-go/quic-go v0.42.0 // indirect
-	github.com/quic-go/webtransport-go v0.7.0 // indirect
+	github.com/quic-go/quic-go v0.45.0 // indirect
+	github.com/quic-go/webtransport-go v0.8.0 // indirect
 	github.com/raulk/go-watchdog v1.3.0 // indirect
 	github.com/russross/blackfriday/v2 v2.1.0 // indirect
 	github.com/samber/lo v1.39.0 // indirect
 	github.com/spaolacci/murmur3 v1.1.0 // indirect
 	github.com/stretchr/objx v0.5.2 // indirect
 	github.com/whyrusleeping/go-keyspace v0.0.0-20160322163242-5b898ac5add1 // indirect
-	github.com/xrash/smetrics v0.0.0-20240312152122-5f08fbb34913 // indirect
+	github.com/xrash/smetrics v0.0.0-20240521201337-686a1a2994c1 // indirect
 	go.opencensus.io v0.24.0 // indirect
-	go.opentelemetry.io/otel v1.25.0 // indirect
-	go.opentelemetry.io/otel/metric v1.25.0 // indirect
-	go.opentelemetry.io/otel/trace v1.25.0 // indirect
+	go.opentelemetry.io/otel v1.27.0 // indirect
+	go.opentelemetry.io/otel/metric v1.27.0 // indirect
+	go.opentelemetry.io/otel/trace v1.27.0 // indirect
 	go.uber.org/dig v1.17.1 // indirect
-	go.uber.org/fx v1.21.0 // indirect
+	go.uber.org/fx v1.22.0 // indirect
 	go.uber.org/mock v0.4.0 // indirect
 	go.uber.org/multierr v1.11.0 // indirect
 	go.uber.org/zap v1.27.0 // indirect
-	golang.org/x/crypto v0.22.0 // indirect
-	golang.org/x/exp v0.0.0-20240409090435-93d18d7e34b8 // indirect
-	golang.org/x/mod v0.17.0 // indirect
-	golang.org/x/net v0.24.0 // indirect
+	golang.org/x/crypto v0.24.0 // indirect
+	golang.org/x/exp v0.0.0-20240613232115-7f521ea00fb8 // indirect
+	golang.org/x/mod v0.18.0 // indirect
+	golang.org/x/net v0.26.0 // indirect
 	golang.org/x/sync v0.7.0 // indirect
-	golang.org/x/text v0.14.0 // indirect
-	golang.org/x/tools v0.20.0 // indirect
+	golang.org/x/text v0.16.0 // indirect
+	golang.org/x/tools v0.22.0 // indirect
 	gonum.org/v1/gonum v0.15.0 // indirect
-	google.golang.org/protobuf v1.33.0 // indirect
+	google.golang.org/protobuf v1.34.2 // indirect
 	gopkg.in/yaml.v3 v3.0.1 // indirect
-	lukechampine.com/blake3 v1.2.2 // indirect
+	lukechampine.com/blake3 v1.3.0 // indirect
 )

gorelease says:

panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x5e692f]

goroutine 45 [running]:
go/types.(*Checker).handleBailout(0xc000814a00, 0xc000819c10)
	/opt/hostedtoolcache/go/1.22.4/x64/src/go/types/check.go:367 +0x88
panic({0x6a6200?, 0x8e0520?})
	/opt/hostedtoolcache/go/1.22.4/x64/src/runtime/panic.go:770 +0x132
go/types.(*StdSizes).Sizeof(0x0, {0x757fb0, 0x8e3980})
	/opt/hostedtoolcache/go/1.22.4/x64/src/go/types/sizes.go:228 +0x30f
go/types.(*Config).sizeof(...)
	/opt/hostedtoolcache/go/1.22.4/x64/src/go/types/sizes.go:333
go/types.representableConst.func1({0x757fb0?, 0x8e3980?})
	/opt/hostedtoolcache/go/1.22.4/x64/src/go/types/const.go:76 +0x9e
go/types.representableConst({0x759db8, 0x8d8c40}, 0xc000814a00, 0x8e3980, 0x0)
	/opt/hostedtoolcache/go/1.22.4/x64/src/go/types/const.go:92 +0x192
go/types.(*Checker).arrayLength(0xc000814a00, {0x759878, 0xc0007c1d80?})
	/opt/hostedtoolcache/go/1.22.4/x64/src/go/types/typexpr.go:510 +0x2d3
go/types.(*Checker).typInternal(0xc000814a00, {0x759038, 0xc000799470}, 0x0)
	/opt/hostedtoolcache/go/1.22.4/x64/src/go/types/typexpr.go:299 +0x49d
go/types.(*Checker).definedType(0xc000814a00, {0x759038, 0xc000799470}, 0xc0008191f8?)
	/opt/hostedtoolcache/go/1.22.4/x64/src/go/types/typexpr.go:180 +0x37
go/types.(*Checker).varType(0xc000814a00, {0x759038, 0xc000799470})
	/opt/hostedtoolcache/go/1.22.4/x64/src/go/types/typexpr.go:145 +0x25
go/types.(*Checker).structType(0xc000814a00, 0xc0004baff0, 0xc0004baff0?)
	/opt/hostedtoolcache/go/1.22.4/x64/src/go/types/struct.go:113 +0x19f
go/types.(*Checker).typInternal(0xc000814a00, {0x759068, 0xc000011a70}, 0xc0002a24b0)
	/opt/hostedtoolcache/go/1.22.4/x64/src/go/types/typexpr.go:316 +0x1345
go/types.(*Checker).definedType(0xc000814a00, {0x759068, 0xc000011a70}, 0x6eecfb?)
	/opt/hostedtoolcache/go/1.22.4/x64/src/go/types/typexpr.go:180 +0x37
go/types.(*Checker).typeDecl(0xc000814a00, 0xc0002a24b0, 0xc0007c4dc0, 0x0)
	/opt/hostedtoolcache/go/1.22.4/x64/src/go/types/decl.go:615 +0x44d
go/types.(*Checker).objDecl(0xc000814a00, {0x75c218, 0xc0002a24b0}, 0x0)
	/opt/hostedtoolcache/go/1.22.4/x64/src/go/types/decl.go:197 +0xa7f
go/types.(*Checker).packageObjects(0xc000814a00)
	/opt/hostedtoolcache/go/1.22.4/x64/src/go/types/resolver.go:681 +0x425
go/types.(*Checker).checkFiles(0xc000814a00, {0xc000010348, 0x3, 0x3})
	/opt/hostedtoolcache/go/1.22.4/x64/src/go/types/check.go:408 +0x1a5
go/types.(*Checker).Files(...)
	/opt/hostedtoolcache/go/1.22.4/x64/src/go/types/check.go:372
golang.org/x/tools/go/packages.(*loader).loadPackage(0xc00050c000, 0xc0006e0e40)
	/home/runner/go/pkg/mod/golang.org/x/tools@v0.2.0/go/packages/packages.go:1037 +0x932
golang.org/x/tools/go/packages.(*loader).loadRecursive.func1()
	/home/runner/go/pkg/mod/golang.org/x/tools@v0.2.0/go/packages/packages.go:847 +0x1a9
sync.(*Once).doSlow(0x0?, 0x0?)
	/opt/hostedtoolcache/go/1.22.4/x64/src/sync/once.go:74 +0xc2
sync.(*Once).Do(...)
	/opt/hostedtoolcache/go/1.22.4/x64/src/sync/once.go:65
golang.org/x/tools/go/packages.(*loader).loadRecursive(0x0?, 0x0?)
	/home/runner/go/pkg/mod/golang.org/x/tools@v0.2.0/go/packages/packages.go:835 +0x4a
golang.org/x/tools/go/packages.(*loader).loadRecursive.func1.1(0x0?)
	/home/runner/go/pkg/mod/golang.org/x/tools@v0.2.0/go/packages/packages.go:842 +0x26
created by golang.org/x/tools/go/packages.(*loader).loadRecursive.func1 in goroutine 41
	/home/runner/go/pkg/mod/golang.org/x/tools@v0.2.0/go/packages/packages.go:841 +0x94

gocompat says:

Your branch is up to date with 'origin/main'.

Automatically created GitHub Release

A draft GitHub Release has been created.
It is going to be published when this PR is merged.
You can modify its' body to include any release notes you wish to include with the release.

@galargh
Copy link
Contributor

galargh commented Jun 25, 2024

I created an issue for handling the secondary rate limits - ipdxco/unified-github-workflows#70

As for the gorelease output, that seems to be connected to the binary being released itself, isn't it?

@lidel
Copy link
Member Author

lidel commented Jun 25, 2024

Did some digging, the job uses old version of gorelease (hardcoded to version golang.org/x/exp/cmd/gorelease@f062dba9d201f5ec084d25785efec05637818c00) and we updated to the latest Go here, and it looks like the panic is related to changes in Go Std library.

I've run go install golang.org/x/exp/cmd/gorelease@latest and then gorelease -base v0.2.3 no longer panics, so will proceed with release. Seems the goreleaser version needs to be bumped in UCI.

@lidel lidel marked this pull request as ready for review June 25, 2024 14:41
@lidel lidel merged commit effefee into main Jun 25, 2024
8 checks passed
@lidel lidel deleted the chore/reelease-0.3.0 branch June 25, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants