Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip over ads with empty metadata #1148

Closed
masih opened this issue Jan 17, 2023 · 0 comments · Fixed by #1151
Closed

Skip over ads with empty metadata #1148

masih opened this issue Jan 17, 2023 · 0 comments · Fixed by #1151
Assignees
@gammazero

Comments

@masih
Copy link
Member

masih commented Jan 17, 2023

If the metadata update fails due to metadata value being empty the ingest of remaining ads in the chain is halted since such error codes are not skipped over.

Ideally, the indexer should detect that the error is caused by invalid metadata and gracefully skip over the ad allowing the ingest to continue.

Cc @dirkmc
@gammazero gammazero self-assigned this Jan 18, 2023
gammazero added a commit that referenced this issue Jan 18, 2023
@gammazero
Skip advertisements that have no metadata
a32f9da 
If an ad has no entries and no metadata, then it used only to update provider addresses and is not an error.

If an ad has entries but no metadata, then an error is logged an the ad is skipped.

Fixes #1148
@gammazero gammazero mentioned this issue Jan 18, 2023
Merged
gammazero added a commit that referenced this issue Jan 18, 2023
@gammazero
Skip advertisements that have no metadata (#1151)
1d04768 
* Skip advertisements that have no metadata

If an ad has no entries and no metadata, then it used only to update provider addresses and is not an error.

If an ad has entries but no metadata, then an error is logged an the ad is skipped.

Fixes #1148
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gammazero gammazero

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Skip advertisements that have no metadata ipni/storetheindex
2 participants
@masih @gammazero