Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip advertisements that have no metadata #1151

Merged
merged 2 commits into from
Jan 18, 2023
Merged

Conversation

gammazero
Copy link
Collaborator

If an ad has no entries and no metadata, then it used only to update provider addresses and is not an error.

If an ad has entries but no metadata, then an error is logged an the ad is skipped.

Fixes #1148

If an ad has no entries and no metadata, then it used only to update provider addresses and is not an error.

If an ad has entries but no metadata, then an error is logged an the ad is skipped.

Fixes #1148
@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2023

Codecov Report

Base: 54.21% // Head: 54.13% // Decreases project coverage by -0.08% ⚠️

Coverage data is based on head (2ea5cfc) compared to base (77fb07b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1151      +/-   ##
==========================================
- Coverage   54.21%   54.13%   -0.08%     
==========================================
  Files         148      147       -1     
  Lines       14757    14739      -18     
==========================================
- Hits         8000     7979      -21     
- Misses       5884     5887       +3     
  Partials      873      873              
Impacted Files Coverage Δ
internal/ingest/linksystem.go 72.40% <100.00%> (+0.38%) ⬆️
dagsync/test/util.go 80.09% <0.00%> (-2.37%) ⬇️
dagsync/dtsync/sync.go 70.22% <0.00%> (-2.25%) ⬇️
fsutil/disk/usage_windows.go
internal/ingest/ingest.go 69.33% <0.00%> (+0.75%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gammazero gammazero merged commit 1d04768 into main Jan 18, 2023
@gammazero gammazero deleted the skip-empty-metadata branch January 18, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skip over ads with empty metadata
3 participants