Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disconnect dido and kepa from reads in prod #1912

Merged
merged 2 commits into from
Jun 8, 2023
Merged

Conversation

ischasny
Copy link
Collaborator

@ischasny ischasny commented Jun 8, 2023

Leaving oden connected until inga catches up with dag.house. The provider to watch.

Also connect inga to not to break providers endpoint.

@ischasny ischasny requested review from masih and gammazero June 8, 2023 16:58
@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.16 ⚠️

Comparison is base (c6b37e7) 47.88% compared to head (9cb69c0) 47.72%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1912      +/-   ##
==========================================
- Coverage   47.88%   47.72%   -0.16%     
==========================================
  Files          95       95              
  Lines       10250    10250              
==========================================
- Hits         4908     4892      -16     
- Misses       4771     4786      +15     
- Partials      571      572       +1     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@gammazero gammazero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to set the replica count to 0 for those indexers as well?

@ischasny
Copy link
Collaborator Author

ischasny commented Jun 8, 2023

Do you want to set the replica count to 0 for those indexers as well?

I'd leave them running in the background until we are certain that everything is working smoothly. Just in case we need to roll back.

@ischasny ischasny merged commit 0f2ad51 into main Jun 8, 2023
@ischasny ischasny deleted the ischasny-patch-6 branch June 8, 2023 17:27
ischasny added a commit that referenced this pull request Jun 9, 2023
ischasny added a commit that referenced this pull request Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants