fix: override with fastTest as property on regex object #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolves issue when running in frozen environments
legobeat
commented
Feb 21, 2024
| // Avoids overriding in frozen environments | ||
| Reflect.defineProperty(re, 'test', { value: fastTest }) | ||
| } else { | ||
| Object.assign(re, { test: fastTest }) |
There was a problem hiding this comment.
This preserves existing behavior when re is string while only objects can be handled with defineProperty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The optimized fastTests for common patterns work by overwriting the
testproperty on aRegExpinstance. This can cause issues in some locked down runtime environments or trip up static analysis tools.This uses
definePropertyto override thetestproperty on the RegExp instance instead.