Args+kwargs with redis 3 #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 83cc432)
Rejects when a job's interval is lower than a queue's interval. Rejects when a job's interval is not a multiple of a queue's interval. This seemed to be the most restrictive approach from which things can be loosened up. Added a settings parameter DJANGO_RQ_SCHEDULER_INTERVAL that can be used to change the schedular interval. Default is 60 matching DJANGO_RQ's default. Renamed migration adding seconds to be more descriptive.
De-duped code and renamed QueueMixin, which had grown to be more than just that. Fixed bug where user without delete permission would get error due to `del actions['delete_selected']` not existing in actions. Delete, bulk enable, and bulk disable all give messages of their success status. Made clear cron string times are in UTC.
With RQ geting a version 1.0 (from 0.13) several other packages had releases w. backwards incompatible changes (Django-RQ's v2.0 for example). This update enforces these changes and bumps rq-rcheduler due to tests failing w. lower versions. Also fixes an issue in this package causing a problem due to changes in redis v3.
Also changes Validation errors to better fit what's suggested in documentation.
Viewable to users with change permission. Pulls timeout and result_ttl from job if present. Does NOT decrement repeat count on repeatable job 🤔.
…rovements # Conflicts: # scheduler/models.py
RepeatableJob's clean_result_ttl only raises the ValidationError to protect against a result_ttl shorter than the interval when there are repeats remaining. The test was set with 0 repeats.
RepeatableJob's clean_result_ttl only raises the ValidationError to protect against a result_ttl shorter than the interval when there are repeats remaining. The test was set with 0 repeats. "Times are in UTC" added to field help text.
Both models allow for integer, string, datetime, and boolean inputs and can be extended to other argument types fairly simply.
Also small changes to testproject showing the django-rq queues.
Seconds interval units
merge upstream
…into bug_fixes_and_improvements # Conflicts: # setup.py
…3.0, bugfix * Bugfix: rq scheduler's enqueue_at takes in a `job_result_ttl` not `result_ttl` kwarg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Written to address Issue #1 and builds the fixes presented in PR #34 and replaces PR #24 due to a re-write of the code there.