fix: Honor eager setting (false by default) #1179
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This delays loading of istanbul-lib-instrument until it is needed.
This fixes a performance regression caused by #985, adds tests to prevent in the future. To test you can create a script
eager.js
:Then you can test the effect of non-eager loading:
Running under nyc with
eager: true
(or without this patch) results in 293 additional modules being loaded, this patch by default reduces the "always load" to 143. This is demonstrated here by ensuring that all sources are excluded from instrument but in practice large test suites that load sources from multiple processes would see benefit when caching-transform bypasses repeated instruments.