Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize lib/instrumenters. #985

Merged
merged 1 commit into from
Feb 5, 2019
Merged

Modernize lib/instrumenters. #985

merged 1 commit into from
Feb 5, 2019

Conversation

coreyfarrell
Copy link
Member

Take advantage of features available in node.js 6 and above

  • Remove unreachable code for importing legacy istanbul module.
  • Use const where possible
  • Use object destructuring where appropriate.
  • Use short-hand function declarations

bcoe
bcoe approved these changes Feb 3, 2019
View reviewed changes
Copy link
Member

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems like a nice little cleanup to me 👍

@coreyfarrell coreyfarrell merged commit 8a5e222 into istanbuljs:master Feb 5, 2019
@coreyfarrell coreyfarrell deleted the modernize-instrumenters branch February 5, 2019 01:38
@coreyfarrell coreyfarrell restored the modernize-instrumenters branch February 5, 2019 01:39
@coreyfarrell coreyfarrell deleted the modernize-instrumenters branch February 5, 2019 01:56
@coreyfarrell coreyfarrell mentioned this pull request Sep 14, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcoe bcoe bcoe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coreyfarrell @bcoe