Skip to content

Commit

Permalink
[release-1.20] GRPC-WEB is a valid port protocol, but not listed (#2989)
Browse files Browse the repository at this point in the history
* GRPC-WEB is a valid port protocol, but not listed correctly in the docs.

Adopted from istio/istio.io#10942.

* Add generated files

---------

Co-authored-by: Craig Box <craigb@armosec.io>
  • Loading branch information
istio-testing and craigbox committed Nov 15, 2023
1 parent 871b291 commit a00678a
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion networking/v1alpha3/gateway.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion networking/v1alpha3/gateway.pb.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion networking/v1alpha3/gateway.proto
Original file line number Diff line number Diff line change
Expand Up @@ -597,7 +597,7 @@ message Port {
uint32 number = 1 [(google.api.field_behavior) = REQUIRED];

// The protocol exposed on the port.
// MUST BE one of HTTP|HTTPS|GRPC|HTTP2|MONGO|TCP|TLS.
// MUST BE one of HTTP|HTTPS|GRPC|GRPC-WEB|HTTP2|MONGO|TCP|TLS.
// TLS can be either used to terminate non-HTTP based connections on a specific port
// or to route traffic based on SNI header to the destination without terminating the TLS connection.
string protocol = 2 [(google.api.field_behavior) = REQUIRED];
Expand Down
2 changes: 1 addition & 1 deletion networking/v1beta1/gateway.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion networking/v1beta1/gateway.proto
Original file line number Diff line number Diff line change
Expand Up @@ -597,7 +597,7 @@ message Port {
uint32 number = 1 [(google.api.field_behavior) = REQUIRED];

// The protocol exposed on the port.
// MUST BE one of HTTP|HTTPS|GRPC|HTTP2|MONGO|TCP|TLS.
// MUST BE one of HTTP|HTTPS|GRPC|GRPC-WEB|HTTP2|MONGO|TCP|TLS.
// TLS can be either used to terminate non-HTTP based connections on a specific port
// or to route traffic based on SNI header to the destination without terminating the TLS connection.
string protocol = 2 [(google.api.field_behavior) = REQUIRED];
Expand Down

0 comments on commit a00678a

Please sign in to comment.