-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add GRPC-WEB to docs about gateway protocols #10942
Conversation
😊 Welcome! This is either your first contribution to the Istio documentation repo, or
Thanks for contributing! Courtesy of your friendly welcome wagon. |
Hi @mmatheson. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
debe4ba
to
d9ab3c3
Compare
d9ab3c3
to
133b556
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This document is copied from the istio/api repo and the change needs to be made there.
See: https://github.com/istio/api/blob/master/networking/v1alpha3/gateway.proto#L599-L602
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@mmatheson: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
correctly in the docs. Adopted from istio/istio.io#10942.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm taking this forward for you in istio/api#2986.
* GRPC-WEB is a valid port protocol, but not listed correctly in the docs. Adopted from istio/istio.io#10942. * Add generated files
* GRPC-WEB is a valid port protocol, but not listed correctly in the docs. Adopted from istio/istio.io#10942. * Add generated files --------- Co-authored-by: Craig Box <craigb@armosec.io>
Please provide a description for what this PR is for.
GRPC-WEB
is a valid port protocol, but not listed correctly in the docs.And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.