Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add GRPC-WEB to docs about gateway protocols #10942

Closed
wants to merge 1 commit into from

Conversation

mmatheson
Copy link

@mmatheson mmatheson commented Feb 18, 2022

Please provide a description for what this PR is for.
GRPC-WEB is a valid port protocol, but not listed correctly in the docs.

And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.

  • Configuration Infrastructure
  • Docs
  • Installation
  • Networking
  • Performance and Scalability
  • Policies and Telemetry
  • Security
  • Test and Release
  • User Experience
  • Developer Infrastructure

@istio-policy-bot
Copy link

😊 Welcome! This is either your first contribution to the Istio documentation repo, or
it's been awhile since you've been here. A few things you should know:

  • You can learn about how we write and maintain documentation, about our style guidelines,
    and about all the available web site features by visiting Contributing to the Docs.

  • In the next few minutes, an automatic preview of your change will be
    built as a full copy of the istio.io website. You can find this preview by clicking on
    the Details link next to the deploy/netlify entry in the Status section of this
    page.

  • We care about quality, so we've put in place a number of checks to ensure our documentation
    is top notch. We do spell checking, we sanitize the markdown, we ensure all hyperlinks point
    to valid location, and more. If your PR doesn't pass one of these checks, you'll see a red X in the
    status section of the page. Click on the Details link to get a list of the problems with your PR.
    Fix those problems and push an update to your PR. This will automatically rerun the tests and
    hopefully this time everything will be perfect.

  • Once your changes are accepted and merged into the repository, they will initially show up
    on https://preliminary.istio.io. The changes will be published to https://istio.io
    the next time we do a major release (which typically happens every 3 months or so).

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 18, 2022
@istio-testing
Copy link
Contributor

Hi @mmatheson. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Feb 22, 2022
Copy link
Contributor

@ericvn ericvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This document is copied from the istio/api repo and the change needs to be made there.

See: https://github.com/istio/api/blob/master/networking/v1alpha3/gateway.proto#L599-L602

@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Jan 25, 2023
@istio-testing
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@istio-testing
Copy link
Contributor

@mmatheson: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
doc.test.profile_none_istio.io 133b556 link true /test doc.test.profile_none
doc.test.profile_demo_istio.io 133b556 link true /test doc.test.profile_demo
doc.test.multicluster_istio.io 133b556 link true /test doc.test.multicluster
doc.test.profile_default_istio.io 133b556 link true /test doc.test.profile_default
doc.test.profile_minimal_istio.io 133b556 link true /test doc.test.profile_minimal
doc.test.profile-demo_istio.io 133b556 link true /test doc.test.profile-demo
doc.test.profile-default_istio.io 133b556 link true /test doc.test.profile-default
doc.test.profile-none_istio.io 133b556 link true /test doc.test.profile-none
doc.test.profile-minimal_istio.io 133b556 link true /test doc.test.profile-minimal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

craigbox added a commit to istio/api that referenced this pull request Nov 9, 2023
Copy link
Contributor

@craigbox craigbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm taking this forward for you in istio/api#2986.

@craigbox craigbox closed this Nov 9, 2023
istio-testing pushed a commit to istio/api that referenced this pull request Nov 10, 2023
* GRPC-WEB is a valid port protocol, but not listed
correctly in the docs.

Adopted from istio/istio.io#10942.

* Add generated files
istio-testing pushed a commit to istio-testing/api that referenced this pull request Nov 13, 2023
istio-testing added a commit to istio/api that referenced this pull request Nov 15, 2023
* GRPC-WEB is a valid port protocol, but not listed correctly in the docs.

Adopted from istio/istio.io#10942.

* Add generated files

---------

Co-authored-by: Craig Box <craigb@armosec.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/docs needs-rebase Indicates a PR needs to be rebased before being merged ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants