[Edit child] The 'ЗБЕРЕГТИ' button stays enabled when mandatory 'По-батькові' field is empty #962 #974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
litvinets
requested changes
Mar 9, 2022
| @@ -73,7 +73,7 @@ export class CreateChildComponent extends CreateFormComponent implements OnInit, | |||
| this.ChildrenFormArray.valueChanges.pipe( | |||
| takeUntil(this.destroy$), | |||
| ).subscribe((val: boolean) => { | |||
| this.isEmpty = !Boolean(val[0].lastName) || !Boolean(val[0].firstName); | |||
| this.isEmpty = !!!(val[0].lastName) || !!!(val[0].firstName) || !!!(val[0].middleName); | |||
There was a problem hiding this comment.
!val[0].lastName
!val[0].firstName
!val[0].middleName
There was a problem hiding this comment.
wrong typo? Why val is boolean but has lastName, firstName?
There was a problem hiding this comment.
I think you should simplify is to !(val[0].lastName || val[0].firstName || val[0].middleName)
There was a problem hiding this comment.
Thank you) Fixed it.
litvinets
requested changes
Mar 9, 2022
| @@ -73,7 +73,7 @@ export class CreateChildComponent extends CreateFormComponent implements OnInit, | |||
| this.ChildrenFormArray.valueChanges.pipe( | |||
| takeUntil(this.destroy$), | |||
| ).subscribe((val: boolean) => { | |||
dmitryy90
approved these changes
Mar 11, 2022
dmitryy90
approved these changes
Mar 14, 2022
litvinets
approved these changes
Mar 14, 2022
|
link this issue please (#965) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Edit child] The 'ЗБЕРЕГТИ' button stays enabled when mandatory 'По-батькові' field is empty #962