Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Edit child] The 'ЗБЕРЕГТИ' button stays enabled when mandatory 'По-батькові' field is empty #962 #974

Merged
merged 13 commits into from
Mar 18, 2022
Merged

[Edit child] The 'ЗБЕРЕГТИ' button stays enabled when mandatory 'По-батькові' field is empty #962 #974

Changes from 2 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
9fe0d98
enable save btn for empty middleName
Olya-web7 Mar 8, 2022
9021b96
enable save btn for empty middleName
Olya-web7 Mar 8, 2022
cdd3532
fix
Olya-web7 Mar 9, 2022
e3eda1b
fix
Olya-web7 Mar 9, 2022
725c29d
Merge branch 'develop' into edit-child-962
Olya-web7 Mar 12, 2022
e94c757
fix
Olya-web7 Mar 12, 2022
d5e9a1c
Merge branch 'edit-child-962' of https://github.com/ita-social-projec…
Olya-web7 Mar 12, 2022
8831f2f
Merge branch 'develop' into edit-child-962
Olya-web7 Mar 13, 2022
1992648
fix
Olya-web7 Mar 13, 2022
ee16afb
Merge branch 'edit-child-962' of https://github.com/ita-social-projec…
Olya-web7 Mar 13, 2022
2a400e4
fix
Olya-web7 Mar 16, 2022
396566b
fix
Olya-web7 Mar 16, 2022
cf09943
Merge branch 'develop' into edit-child-962
Olya-web7 Mar 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/app/shell/personal-cabinet/parent/create-child/create-child.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ export class CreateChildComponent extends CreateFormComponent implements OnInit,
this.ChildrenFormArray.valueChanges.pipe(
takeUntil(this.destroy$),
).subscribe((val: boolean) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change please typo

this.isEmpty = !Boolean(val[0].lastName) || !Boolean(val[0].firstName);
this.isEmpty = !!!(val[0].lastName) || !!!(val[0].firstName) || !!!(val[0].middleName);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!val[0].lastName
!val[0].firstName
!val[0].middleName

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong typo? Why val is boolean but has lastName, firstName?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should simplify is to !(val[0].lastName || val[0].firstName || val[0].middleName)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you) Fixed it.

});

}
Expand Down