Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add back old pytorch_lightning imports #627

Merged
merged 1 commit into from
Jul 14, 2023
Merged

add back old pytorch_lightning imports #627

merged 1 commit into from
Jul 14, 2023

Conversation

dberenbaum
Copy link
Collaborator

Fixes #625

@dberenbaum dberenbaum requested a review from daavoo July 14, 2023 15:21
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.15 ⚠️

Comparison is base (28a0224) 89.69% compared to head (269c4b2) 89.54%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #627      +/-   ##
==========================================
- Coverage   89.69%   89.54%   -0.15%     
==========================================
  Files          43       43              
  Lines        2988     2993       +5     
  Branches      250      250              
==========================================
  Hits         2680     2680              
- Misses        269      274       +5     
  Partials       39       39              
Impacted Files Coverage Δ
src/dvclive/lightning.py 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dberenbaum dberenbaum merged commit fbb9c52 into main Jul 14, 2023
10 checks passed
@dberenbaum dberenbaum deleted the lightning-import branch July 14, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ModuleNotFoundError: No module named 'lightning'
3 participants