Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add back old pytorch_lightning imports #627

Merged
merged 1 commit into from
Jul 14, 2023
Merged

add back old pytorch_lightning imports #627

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions src/dvclive/lightning.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,23 @@
import inspect
from typing import Any, Dict, Optional

from lightning.fabric.utilities.logger import (
_convert_params,
_sanitize_callable_params,
_sanitize_params,
)
from lightning.pytorch.loggers.logger import Logger, rank_zero_experiment
from lightning.pytorch.utilities import rank_zero_only
try:
from lightning.fabric.utilities.logger import (
_convert_params,
_sanitize_callable_params,
_sanitize_params,
)
from lightning.pytorch.loggers.logger import Logger, rank_zero_experiment
from lightning.pytorch.utilities import rank_zero_only
except ImportError:
from lightning_fabric.utilities.logger import (
_convert_params,
_sanitize_callable_params,
_sanitize_params,
)
from pytorch_lightning.loggers.logger import Logger, rank_zero_experiment
from pytorch_lightning.utilities import rank_zero_only

from torch import is_tensor

from dvclive import Live
Expand Down