Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow downstream type checking #111

Merged
merged 4 commits into from
Dec 22, 2021
Merged

Allow downstream type checking #111

merged 4 commits into from
Dec 22, 2021

Conversation

daneah
Copy link
Member

@daneah daneah commented Dec 21, 2021

This change is a: (check at least one)

  • Bugfix
  • Feature addition
  • Code style update
  • Refactor
  • Release activity

Is this a breaking change? (check one)

  • Yes
  • No

Is the:

  • Title of this pull request clear, concise, and indicative of the issue number it addresses, if any?
  • Test suite passing?
  • Code coverage maximal?
  • Changelog up to date?

What does this change address?

This package has type hints, which are checked for self-consistency. Downstream packages may have type hints, also checked for self-consistency. Without a py.typed file, downstream applications can't check for consistency against this package.

How does this change work?

Create a py.typed file and include it via MANIFEST.in.

Additional context

Updated sphinx because the docs were failing to build against Python 3.10.

@daneah daneah added the ✨ enhancement New feature or request label Dec 21, 2021
@daneah daneah merged commit 3114936 into dev Dec 22, 2021
@daneah daneah deleted the allow-downstream-type-checking branch December 22, 2021 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants