Improve internal and downstream type checking #121
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is a: (check at least one)
Is this a breaking change? (check one)
Is the:
What does this change address?
We added
py.typed
files in #111 but they would only appear in the source distribution throughMANIFEST.in
;include_package_data = True
is required for the files to land in the binary wheel distribution.We've also got a few things to get up to speed on regarding tooling configuration.
How does this change work?
include_package_data = True
insetup.cfg
.Optional
syntax to comply with PEP 484 and mypy's more strict checking of itAdditional context
This can break consumers' type checking because this package would have previously needed to be ignored by mypy for lack of types; now it can be included, but consumers may find their usage does not type check.