Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execute notebooks on rtd. Closes #469 #470

Merged
merged 7 commits into from
Dec 31, 2022
Merged

Execute notebooks on rtd. Closes #469 #470

merged 7 commits into from
Dec 31, 2022

Conversation

hmgaudecker
Copy link
Collaborator

@hmgaudecker hmgaudecker commented Dec 22, 2022

What problem do you want to solve?

Automate building the documentation.

  • Execute notebooks as part of the rtd build.
  • Add pre-commit hook to commit empty notebooks only
  • Use mamba on rtd
  • Document PR in docs/changes.rst.

@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Base: 91.41% // Head: 91.41% // No change to project coverage 👍

Coverage data is based on head (6e81467) compared to base (a672088).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #470   +/-   ##
=======================================
  Coverage   91.41%   91.41%           
=======================================
  Files          77       77           
  Lines        4006     4006           
=======================================
  Hits         3662     3662           
  Misses        344      344           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hmgaudecker hmgaudecker requested a review from janosg December 22, 2022 12:02
Copy link
Collaborator

@janosg janosg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Just one stupid question: I don't see where you trigger the actual build of the notebook such that it is displayed with output in the online documentation. Is this a readthedocs setting or did I miss something?

@hmgaudecker
Copy link
Collaborator Author

I don't see where you trigger the actual build of the notebook such that it is displayed with output in the online documentation.

This is nbsphinx' default behaviour: https://nbsphinx.readthedocs.io/en/0.8.11/usage.html#nbsphinx_execute

Other useful references:

@hmgaudecker hmgaudecker merged commit 7f6afea into main Dec 31, 2022
@hmgaudecker hmgaudecker deleted the execute-notebooks branch December 31, 2022 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants