-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve infrastructure (CI, Linting, Docs Build) #420
Conversation
Codecov Report
@@ Coverage Diff @@
## main #420 +/- ##
==========================================
- Coverage 92.88% 92.82% -0.07%
==========================================
Files 223 223
Lines 17396 17459 +63
==========================================
+ Hits 16158 16206 +48
- Misses 1238 1253 +15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Broadening the scope a bit... |
Some economies of scope with the review of GETTSIM #470 here -- exactly the same 😄 |
a1e6d73
to
9bb84db
Compare
1907133
to
ba5497b
Compare
Runtime of github actions is roughly cut in half due to mamba and caching environments. I also got rid of tox entirely. @hmgaudecker maybe you want to copy this for gettsim. |
Turns out that the notebooks were not actually executed on readthedocs and shown without outputs, due to this line in conf.py: nbsphinx_execute = "never" Unfortunately, they also run way too long to be executed remotely. So I keep the mamba changes but otherwise revert to building notebooks locally and committing them with outputs. |
Do all notebooks run for too long? Else use |
If there is need for speed.