[jaeger] - allinone use tpl function for args #428
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pierre Tessier pierre@pierretessier.com
What this PR does
Uses the Helm tpl function to allow for command line args to be templated. This is required when Jaeger is used as a chart dependency and some options can only be determined at helm templating time (ie: release name).
Which issue this PR fixes
This allows for the OpenTelemetry demo to leverage Jaeger for tracing with Prometheus-backed metrics store configured in the Jaeger AllInOne deploy as merged recently in the otel demo PR 655
The OpenTelemetry demo helm chart will have a section to configure the prometheus sever url that looks like this:
Passing in the
{{ include "otel-demo.name" .}}
portion for the command line argument is what this PR enables.Checklist
[jaeger]
or[jaeger-operator]
)