Jaeger-SPM-Config #655
Merged
Jaeger-SPM-Config #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--prometheus.server-url parameter and environment variable METRICS_STORAGE_TYPE=prometheus added to make Jaeger SPM page working.
prometheus.server-url parameter and environment variable
prometheus.server-url
mviitane
reviewed
Dec 23, 2022
There was a problem hiding this comment.
Looks good and seems to work fine!
@devrimdemiroz, can you still fix the yamllint problem (add spaces after commas)?
puckpuck
requested changes
Dec 24, 2022
puckpuck
added
the
helm-update-required
commited to test in local. will be resolving once it works. Co-authored-by: Pierre Tessier <pierre@pierretessier.com>
puckpuck
approved these changes
Dec 24, 2022
|
Please add a changelog entry, and cleanup the failed checks. |
mviitane
approved these changes
Dec 25, 2022
julianocosta89
approved these changes
Dec 25, 2022
|
So to make this change work with the Helm chart will require an update to the Jaeger helm chart to accept passing in templated variables properly. Managing dependencies is fun 🤪 |
5 tasks
jmichalak9
pushed a commit
to jmichalak9/opentelemetry-demo
that referenced
this pull request
Mar 22, 2024
* prometheus.server-url parameter --prometheus.server-url parameter and environment variable METRICS_STORAGE_TYPE=prometheus added to make Jaeger SPM page working. * prometheus.server-url prometheus.server-url parameter and environment variable * Update docker-compose.yml commited to test in local. will be resolving once it works. Co-authored-by: Pierre Tessier <pierre@pierretessier.com> * lint typo correctin * Update CHANGELOG.md * Add Jaeger-SPM-Config ([open-telemetry#655](open-telemetry#655)) * remove extra blank space Co-authored-by: Pierre Tessier <pierre@pierretessier.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
prometheus.server-url parameter and environment variable - METRICS_STORAGE_TYPE=prometheus added. So that Jaeger SPM window now shows spanmetrics.
It is not a crucial need as Jager would already be datasourced by Grafana. Nevertheless, it is nice to have.
Merge Requirements
For new features contributions please make sure you have completed the following
essential items:
CHANGELOG.mdupdated to document new feature additionsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.