Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jaeger] Update Jaeger version in helm chart #544

Closed

Conversation

tronda
Copy link

@tronda tronda commented Mar 12, 2024

What this PR does

Update to the latest released Jaeger version.

Which issue this PR fixes

None

Checklist

  • DCO signed
  • Commits are GPG signed
  • Chart Version bumped
  • Title of the PR starts with chart name ([jaeger] or [jaeger-operator])
  • README.md has been updated to match version/contain new values

Signed-off-by: Trond Andersen <tra@dips.no>
@tronda
Copy link
Author

tronda commented Mar 13, 2024

Not sure why the Kafka related template fails for this change.

@pavelnikolov
Copy link
Contributor

Maybe we can leave the Kafka sub-chart version untouched for now 🤔

Signed-off-by: Trond Andersen <tra@dips.no>
@tronda
Copy link
Author

tronda commented Mar 14, 2024

Maybe we can leave the Kafka sub-chart version untouched for now 🤔

I've pinned the Kafka chart on the previous version with the latest commit.

Signed-off-by: Trond Andersen <trond.andersen@gmail.com>
@bens545
Copy link
Contributor

bens545 commented Mar 19, 2024

It's likely still failing due to the common chart update. Try reverting it to the previous version and testing.

Signed-off-by: Trond Andersen <tra@dips.no>
@tronda tronda force-pushed the feature/tra-update_jaeger_dependencies branch from 9c88cd3 to e61d541 Compare March 25, 2024 07:39
@alex1989hu
Copy link
Contributor

@tronda is there any particular reason (probably I overlooked it) why appVersion change is not enough here?

On the other hand, role.yaml must be also updated due to

@tronda
Copy link
Author

tronda commented Apr 16, 2024

@tronda is there any particular reason (probably I overlooked it) why appVersion change is not enough here?

I just wanted the latest version of Jaeger by default with the helm chart and my own preference to always update to the latest dependencies.

On the other hand, role.yaml must be also updated due to

Probably somebody else should do the update since I don't know the details here.

@tronda tronda closed this Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants