Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the host set in the Ingess field for the OpenShift Route #2409

Merged
merged 3 commits into from
Mar 7, 2024

Conversation

iblancasa
Copy link
Collaborator

Resolves #2334

@iblancasa iblancasa requested a review from rubenvp8510 January 5, 2024 14:02
@iblancasa iblancasa self-assigned this Jan 5, 2024
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: Patch coverage is 22.22222% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 87.69%. Comparing base (173ad1e) to head (b16416c).

Files Patch % Lines
pkg/route/query.go 22.22% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2409      +/-   ##
==========================================
- Coverage   87.71%   87.69%   -0.02%     
==========================================
  Files         102      102              
  Lines        7269     7274       +5     
==========================================
+ Hits         6376     6379       +3     
- Misses        697      699       +2     
  Partials      196      196              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com>
@iblancasa iblancasa merged commit 2583d2a into jaegertracing:main Mar 7, 2024
35 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: On Openshift, jaeger-operator does not respect hosts set in ingress section
2 participants