Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change start/end time to non-nullable #109

Merged
merged 3 commits into from
Nov 17, 2024

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Nov 17, 2024

Which problem is this PR solving?

Description of the changes

  • Make time values non-nullable to avoid pointers

How was this change tested?

Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro mentioned this pull request Nov 17, 2024
4 tasks
@yurishkuro yurishkuro merged commit 7728794 into jaegertracing:main Nov 17, 2024
2 checks passed
@yurishkuro yurishkuro deleted the get-trace-time-range branch November 17, 2024 21:42
yurishkuro added a commit to jaegertracing/jaeger that referenced this pull request Nov 18, 2024
## Which problem is this PR solving?
- Part of #4150

## Description of the changes
- Sync to latest jaeger-idl (inculding
jaegertracing/jaeger-idl#109)
- Regenerate protobuf

## How was this change tested?
- CI

---------

Signed-off-by: Yuri Shkuro <github@ysh.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant