Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change start/end time in GetTrace request to not be pointers #6218

Merged
merged 5 commits into from
Nov 18, 2024

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Nov 17, 2024

Which problem is this PR solving?

Description of the changes

How was this change tested?

  • CI

Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Copy link

codecov bot commented Nov 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.49%. Comparing base (5475a36) to head (7c7eb70).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6218      +/-   ##
==========================================
+ Coverage   96.25%   96.49%   +0.23%     
==========================================
  Files         354      354              
  Lines       20134    20134              
==========================================
+ Hits        19380    19428      +48     
+ Misses        571      522      -49     
- Partials      183      184       +1     
Flag Coverage Δ
badger_v1 8.31% <ø> (ø)
badger_v2 1.67% <ø> (ø)
cassandra-4.x-v1 14.39% <ø> (ø)
cassandra-4.x-v2 1.61% <ø> (ø)
cassandra-5.x-v1 14.39% <ø> (ø)
cassandra-5.x-v2 1.61% <ø> (ø)
elasticsearch-6.x-v1 18.59% <ø> (-0.01%) ⬇️
elasticsearch-7.x-v1 18.67% <ø> (-0.01%) ⬇️
elasticsearch-8.x-v1 18.85% <ø> (+<0.01%) ⬆️
elasticsearch-8.x-v2 1.67% <ø> (ø)
grpc_v1 9.47% <ø> (ø)
grpc_v2 7.00% <ø> (ø)
kafka-v1 8.88% <ø> (?)
kafka-v2 1.67% <ø> (ø)
memory_v2 1.66% <ø> (-0.01%) ⬇️
opensearch-1.x-v1 18.73% <ø> (+<0.01%) ⬆️
opensearch-2.x-v1 18.72% <ø> (-0.01%) ⬇️
opensearch-2.x-v2 1.67% <ø> (ø)
tailsampling-processor 0.46% <ø> (ø)
unittests 95.40% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

yurishkuro added a commit to jaegertracing/jaeger-idl that referenced this pull request Nov 17, 2024
## Which problem is this PR solving?
- Part of jaegertracing/jaeger#4150

## Description of the changes
- Make time values non-nullable to avoid pointers

## How was this change tested?
- In jaegertracing/jaeger#6218

---------

Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro changed the title WIP Start end time Change start/end time in GetTrace request to not be pointers Nov 17, 2024
@yurishkuro yurishkuro marked this pull request as ready for review November 17, 2024 21:45
@yurishkuro yurishkuro requested a review from a team as a code owner November 17, 2024 21:45
@yurishkuro yurishkuro merged commit 684ec99 into jaegertracing:main Nov 18, 2024
52 checks passed
@yurishkuro yurishkuro deleted the start-end-time branch November 18, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants