-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change start/end time in GetTrace request to not be pointers #6218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6218 +/- ##
==========================================
+ Coverage 96.25% 96.49% +0.23%
==========================================
Files 354 354
Lines 20134 20134
==========================================
+ Hits 19380 19428 +48
+ Misses 571 522 -49
- Partials 183 184 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This was referenced Nov 17, 2024
yurishkuro
added a commit
to jaegertracing/jaeger-idl
that referenced
this pull request
Nov 17, 2024
## Which problem is this PR solving? - Part of jaegertracing/jaeger#4150 ## Description of the changes - Make time values non-nullable to avoid pointers ## How was this change tested? - In jaegertracing/jaeger#6218 --------- Signed-off-by: Yuri Shkuro <github@ysh.us>
yurishkuro
changed the title
WIP Start end time
Change start/end time in GetTrace request to not be pointers
Nov 17, 2024
mahadzaryab1
approved these changes
Nov 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?