-
Notifications
You must be signed in to change notification settings - Fork 487
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
## Which problem is this PR solving? lerna/nx does not support s390x, and therefore the jaeger-ui build fails on this platform. This PR removes the lerna dependency from jaeger-ui. https://github.com/nrwl/nx/blob/16.6.0/packages/nx/src/native/index.js#L161 https://github.com/nrwl/nx/blob/16.6.0/docs/shared/installation/troubleshoot-installation.md#supported-native-module-platforms Resolves: #1996 Resolves: #341 ## Description of the changes Remove `lerna` and use `yarn workspaces` instead. ## How was this change tested? - local ## Checklist - [X] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [X] I have signed all commits - [ ] I have added unit tests for the new functionality - [ ] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
- Loading branch information
1 parent
7c1692c
commit f391b86
Showing
5 changed files
with
76 additions
and
2,686 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,7 +19,6 @@ npm-debug.log | |
.vscode | ||
.idea | ||
yarn-error.log | ||
lerna-debug.log | ||
.eslintcache | ||
.vscode | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.