Audit use of lerna #341
Labels
Comments
4 tasks
andreasgerstmayr
added a commit
to andreasgerstmayr/jaeger-ui
that referenced
this issue
Nov 22, 2023
lerna/nx does not support s390x: https://github.com/nrwl/nx/blob/16.6.0/packages/nx/src/native/index.js#L161 https://github.com/nrwl/nx/blob/16.6.0/docs/shared/installation/troubleshoot-installation.md#supported-native-module-platforms Resolves: jaegertracing#1996 Resolves: jaegertracing#341 Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
yurishkuro
pushed a commit
that referenced
this issue
Nov 23, 2023
## Which problem is this PR solving? lerna/nx does not support s390x, and therefore the jaeger-ui build fails on this platform. This PR removes the lerna dependency from jaeger-ui. https://github.com/nrwl/nx/blob/16.6.0/packages/nx/src/native/index.js#L161 https://github.com/nrwl/nx/blob/16.6.0/docs/shared/installation/troubleshoot-installation.md#supported-native-module-platforms Resolves: #1996 Resolves: #341 ## Description of the changes Remove `lerna` and use `yarn workspaces` instead. ## How was this change tested? - local ## Checklist - [X] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [X] I have signed all commits - [ ] I have added unit tests for the new functionality - [ ] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Make sure our use of lerna is:
We have ended up relying quite a bit on
yarnworkspaces, which has reduced the relevance oflerna.The text was updated successfully, but these errors were encountered: