-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve get trace name performance #574
Merged
yurishkuro
merged 6 commits into
jaegertracing:master
from
everett980:Improve-getTraceName-performance
May 12, 2020
Merged
Improve get trace name performance #574
yurishkuro
merged 6 commits into
jaegertracing:master
from
everett980:Improve-getTraceName-performance
May 12, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Everett Ross <reverett@uber.com>
Signed-off-by: Everett Ross <reverett@uber.com>
Signed-off-by: Everett Ross <reverett@uber.com>
Codecov Report
@@ Coverage Diff @@
## master #574 +/- ##
==========================================
+ Coverage 89.92% 89.97% +0.04%
==========================================
Files 214 214
Lines 5221 5225 +4
Branches 1334 1338 +4
==========================================
+ Hits 4695 4701 +6
+ Misses 483 481 -2
Partials 43 43
Continue to review full report at Codecov.
|
yurishkuro
approved these changes
May 12, 2020
👏 👏 👏 |
vvvprabhakar
pushed a commit
to vvvprabhakar/jaeger-ui
that referenced
this pull request
Jul 5, 2021
* Memoize getTraceName to improve render time by 3x Signed-off-by: Everett Ross <reverett@uber.com> * Clean up memoization approach Signed-off-by: Everett Ross <reverett@uber.com> * Fix merge Signed-off-by: Everett Ross <reverett@uber.com> * Fix getTraceNameImpl to be O n Signed-off-by: Everett Ross <reverett@uber.com> Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
This was referenced Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
getTraceName
for a trace with 11.5k spans from 20s to 250msShort description of the changes
reduce
ofspans
intoallTraceSpans
with a set ofallIDs
for
loop