Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve get trace name performance #574

Merged
merged 6 commits into from
May 12, 2020
Merged

Improve get trace name performance #574

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d36c0d0
Memoize getTraceName to improve render time by 3x
everett980 May 12, 2020
dcf3f99
Clean up memoization approach
everett980 May 12, 2020
529d6d0
Merge branch 'master' into Improve-getTraceName-performance
everett980 May 12, 2020
74bd2b9
Fix merge
everett980 May 12, 2020
64fffbb
Fix getTraceNameImpl to be O n
everett980 May 12, 2020
7825437
Merge branch 'master' into Improve-getTraceName-performance
everett980 May 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 28 additions & 21 deletions packages/jaeger-ui/src/model/trace-viewer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,28 +16,35 @@ import _memoize from 'lodash/memoize';

import { Span } from '../types/trace';

type spansDict = { [index: string]: Span };

export function _getTraceNameImpl(spans: Span[]) {
const allTraceSpans: spansDict = spans.reduce((dict, span) => ({ ...dict, [span.spanID]: span }), {});
const rootSpan = spans
.filter(sp => {
if (!sp.references || !sp.references.length) {
return true;
}
const parentIDs = sp.references.filter(r => r.traceID === sp.traceID).map(r => r.spanID);

// returns true if no parent from this trace found
return !parentIDs.some(pID => Boolean(allTraceSpans[pID]));
})
.sort((sp1, sp2) => {
const sp1ParentsNum = sp1.references ? sp1.references.length : 0;
const sp2ParentsNum = sp2.references ? sp2.references.length : 0;

return sp1ParentsNum - sp2ParentsNum || sp1.startTime - sp2.startTime;
})[0];

return rootSpan ? `${rootSpan.process.serviceName}: ${rootSpan.operationName}` : '';
// Use a span with no references to another span in given array
// prefering the span with the fewest references
// using start time as a tie breaker
let candidateSpan: Span | undefined;
const allIDs: Set<string> = new Set(spans.map(({ spanID }) => spanID));

for (let i = 0; i < spans.length; i++) {
const hasInternalRef =
spans[i].references &&
spans[i].references.some(({ traceID, spanID }) => traceID === spans[i].traceID && allIDs.has(spanID));
if (hasInternalRef) continue;

if (!candidateSpan) {
candidateSpan = spans[i];
continue;
}

const thisRefLength = (spans[i].references && spans[i].references.length) || 0;
const candidateRefLength = (candidateSpan.references && candidateSpan.references.length) || 0;

if (
thisRefLength < candidateRefLength ||
(thisRefLength === candidateRefLength && spans[i].startTime < candidateSpan.startTime)
) {
candidateSpan = spans[i];
}
}
return candidateSpan ? `${candidateSpan.process.serviceName}: ${candidateSpan.operationName}` : '';
}

export const getTraceName = _memoize(_getTraceNameImpl, (spans: Span[]) => {
Expand Down