REST API for collecting spans #123
Assignees
Comments
|
doing this now for thrift format with endpoint: /api/traces?format=Jaeger.thrift as POST as an endpoint on the collector. |
|
I don't think this is fully solved. For Browser use case we need JSON endpoint. The current binary thrift endpoint is something we need for blackbox monitoring |
|
Sounds good, doing this next: /api/traces?format=Jaeger.json as POST |
|
curious, why are we doing the "Jaeger" prefix for the format? Are we planning on supporting non-jaeger formats in the long distant future? |
|
@black-adder i'd prefer to keep that open as a possibility, yes. |
|
assigning to vprithvi as well, as he is doing some work on http span submissions. |
|
Done, implemented HTTP endpoint for collecting data in jaeger.thrift format and now we have also zipkin |
ghost
assigned 
th3M1ke
added a commit
to th3M1ke/jaeger
that referenced
this issue
Dec 29, 2020
…om jaeger-ui) Signed-off-by: Mykhailo Semenchenko <mykhailo.semenchenko@logz.io>
th3M1ke
added a commit
to th3M1ke/jaeger
that referenced
this issue
Dec 29, 2020
…om jaeger-ui) Signed-off-by: Mykhailo Semenchenko <mykhailo.semenchenko@logz.io>
yurishkuro
pushed a commit
that referenced
this issue
Jan 14, 2021
* Add ability to use JS file for UI configuration (#123 from jaeger-ui) Signed-off-by: Mykhailo Semenchenko <mykhailo.semenchenko@logz.io> * Update UI config file injection Signed-off-by: Mykhailo Semenchenko <mykhailo.semenchenko@logz.io> * Update update test, refactor loadUIConfig function Signed-off-by: Mykhailo Semenchenko <mykhailo.semenchenko@logz.io> * Update errors text, minor refactor Signed-off-by: Mykhailo Semenchenko <mykhailo.semenchenko@logz.io> * Remove debug code Signed-off-by: Mykhailo Semenchenko <mykhailo.semenchenko@logz.io> * Update jaeger-ui to latest master with index.html changes Signed-off-by: Mykhailo Semenchenko <mykhailo.semenchenko@logz.io>
bhiravabhatla
referenced
this issue
in bhiravabhatla/jaeger
Jan 25, 2021
…gertracing#2707) * Add ability to use JS file for UI configuration (#123 from jaeger-ui) Signed-off-by: Mykhailo Semenchenko <mykhailo.semenchenko@logz.io> * Update UI config file injection Signed-off-by: Mykhailo Semenchenko <mykhailo.semenchenko@logz.io> * Update update test, refactor loadUIConfig function Signed-off-by: Mykhailo Semenchenko <mykhailo.semenchenko@logz.io> * Update errors text, minor refactor Signed-off-by: Mykhailo Semenchenko <mykhailo.semenchenko@logz.io> * Remove debug code Signed-off-by: Mykhailo Semenchenko <mykhailo.semenchenko@logz.io> * Update jaeger-ui to latest master with index.html changes Signed-off-by: Mykhailo Semenchenko <mykhailo.semenchenko@logz.io>
yurishkuro
pushed a commit
that referenced
this issue
Dec 8, 2022
Signed-off-by: Joe Elliott <number101010@gmail.com> <!-- Please delete this comment before posting. We appreciate your contribution to the Jaeger project! 👋🎉 Before creating a pull request, please make sure: - Your PR is solving one problem - You have read the guide for contributing - See https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING.md - You signed all your commits (otherwise we won't be able to merge the PR) - See https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md#certificate-of-origin---sign-your-work - You added unit tests for the new functionality - You mention in the PR description which issue it is addressing, e.g. "Resolves #123" --> ## Which problem is this PR solving? - <!-- e.g. Resolves #123 --> ## Short description of the changes - Signed-off-by: Joe Elliott <number101010@gmail.com>
shubbham1215
pushed a commit
to shubbham1215/jaeger
that referenced
this issue
Feb 22, 2023
Signed-off-by: Joe Elliott <number101010@gmail.com> <!-- Please delete this comment before posting. We appreciate your contribution to the Jaeger project! 👋🎉 Before creating a pull request, please make sure: - Your PR is solving one problem - You have read the guide for contributing - See https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING.md - You signed all your commits (otherwise we won't be able to merge the PR) - See https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md#certificate-of-origin---sign-your-work - You added unit tests for the new functionality - You mention in the PR description which issue it is addressing, e.g. "Resolves jaegertracing#123" --> ## Which problem is this PR solving? - <!-- e.g. Resolves jaegertracing#123 --> ## Short description of the changes - Signed-off-by: Joe Elliott <number101010@gmail.com>
shubbham1215
pushed a commit
to shubbham1215/jaeger
that referenced
this issue
Mar 5, 2023
Signed-off-by: Joe Elliott <number101010@gmail.com> <!-- Please delete this comment before posting. We appreciate your contribution to the Jaeger project! 👋🎉 Before creating a pull request, please make sure: - Your PR is solving one problem - You have read the guide for contributing - See https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING.md - You signed all your commits (otherwise we won't be able to merge the PR) - See https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md#certificate-of-origin---sign-your-work - You added unit tests for the new functionality - You mention in the PR description which issue it is addressing, e.g. "Resolves jaegertracing#123" --> ## Which problem is this PR solving? - <!-- e.g. Resolves jaegertracing#123 --> ## Short description of the changes - Signed-off-by: Joe Elliott <number101010@gmail.com> Signed-off-by: shubbham1215 <sawaikershubham@gmail.com>
yurishkuro
pushed a commit
that referenced
this issue
May 11, 2023
<!-- Please delete this comment before posting. We appreciate your contribution to the Jaeger project! 👋🎉 Before creating a pull request, please make sure: - Your PR is solving one problem - You have read the guide for contributing - See https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING.md - You signed all your commits (otherwise we won't be able to merge the PR) - See https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md#certificate-of-origin---sign-your-work - You added unit tests for the new functionality - You mention in the PR description which issue it is addressing, e.g. "Resolves #123" --> ## Which problem is this PR solving? Resolves #4448 ## Short description of the changes Jaeger agent gets stuck when closing with SocketBufferSize set. This is because `Close()` of `net.UDPConn` will be blocked if `Fd()` is used to get the file descriptor. Use `RawConn.Control` instead to get fd to set the socket buffer. Same issue was discussed here: golang/go#29277 The fix refers to here: brucespang/go-tcpinfo#3 Signed-off-by: Chen Xu <chen.x@uber.com>
yurishkuro
pushed a commit
that referenced
this issue
Aug 13, 2023
<!-- Please delete this comment before posting. We appreciate your contribution to the Jaeger project! 👋🎉 Before creating a pull request, please make sure: - Your PR is solving one problem - You have read the guide for contributing - See https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING.md - You signed all your commits (otherwise we won't be able to merge the PR) - See https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md#certificate-of-origin---sign-your-work - You added unit tests for the new functionality - You mention in the PR description which issue it is addressing, e.g. "Resolves #123" --> ## Which problem is this PR solving? * Part of #3381 * This PR removes `opentracing pkg` from jtracer pkg and go.mod file ## Short description of the changes - Removes `opentracing pkg` from `jaeger module` and modifies README file to rmv OT support. --------- Signed-off-by: Afzal Ansari <afzal442@gmail.com>
yurishkuro
added a commit
that referenced
this issue
Feb 19, 2024
## Which problem is this PR solving? - Resolves Issue #5168 <!-- Example: Resolves #123 --> ## Description of the changes - Create a print-config CLI subcommand to print the resolved configurations in the path /cmd/internal/config. It iterates through the settings with viper, returning all the keys that contain a value and printing whether that value is default or not. - Create a --all flag that when called prints all settings, whether they have values or not. Below is an example of the output without a all flag: ``` bash go run cmd/all-in-one/main.go print-config 2024/02/15 13:55:52 maxprocs: Leaving GOMAXPROCS=16: CPU quota undefined 2024/02/15 13:55:52 application version: git-commit=, git-version=, build-date= ------------------------------------------------------------------------------- | Configuration Option Name Value Source | ------------------------------------------------------------------------------- | admin.http.host-port :14269 default | | admin.http.tls.enabled false default | | collector.enable-span-size-metrics false default | | collector.grpc-server.host-port :14250 default | | collector.grpc-server.max-connection-age 0s default | | collector.grpc-server.max-connection-age-grace 0s default | | collector.grpc-server.max-message-size 4194304 default | | collector.grpc.tls.enabled false default | | collector.http-server.host-port :14268 default | | collector.http-server.idle-timeout 0s default | | collector.http-server.read-header-timeout 2s default | | collector.http-server.read-timeout 0s default | | collector.http.tls.enabled false default | | collector.num-workers 50 default | | collector.otlp.enabled true default | | collector.otlp.grpc.max-connection-age 0s default | | collector.otlp.grpc.max-connection-age-grace 0s default | | collector.otlp.grpc.max-message-size 4194304 default | | collector.otlp.grpc.tls.enabled false default | | collector.otlp.grpc.tls.reload-interval 0s default | | collector.otlp.http.idle-timeout 0s default | | collector.otlp.http.read-header-timeout 2s default | | collector.otlp.http.read-timeout 0s default | | collector.otlp.http.tls.enabled false default | | collector.otlp.http.tls.reload-interval 0s default | | collector.queue-size 2000 default | | collector.queue-size-memory 0 default | | collector.zipkin.keep-alive true default | | collector.zipkin.tls.enabled false default | | dir ./ default | | downsampling.ratio 1 default | | format md default | | http-server.host-port :5778 default | | log-level info default | | memory.max-traces 0 default | | metrics-backend prometheus default | | metrics-http-route /metrics default | | multi-tenancy.enabled false default | | multi-tenancy.header x-tenant default | | processor.jaeger-binary.server-host-port :6832 default | | processor.jaeger-binary.server-max-packet-size 65000 default | | processor.jaeger-binary.server-queue-size 1000 default | | processor.jaeger-binary.server-socket-buffer-size 0 default | | processor.jaeger-binary.workers 10 default | | processor.jaeger-compact.server-host-port :6831 default | | processor.jaeger-compact.server-max-packet-size 65000 default | | processor.jaeger-compact.server-queue-size 1000 default | | processor.jaeger-compact.server-socket-buffer-size 0 default | | processor.jaeger-compact.workers 10 default | | processor.zipkin-compact.server-host-port :5775 default | | processor.zipkin-compact.server-max-packet-size 65000 default | | processor.zipkin-compact.server-queue-size 1000 default | | processor.zipkin-compact.server-socket-buffer-size 0 default | | processor.zipkin-compact.workers 10 default | | query.base-path / default | | query.bearer-token-propagation false default | | query.enable-tracing false default | | query.grpc-server.host-port :16685 default | | query.grpc.tls.enabled false default | | query.http-server.host-port :16686 default | | query.http.tls.enabled false default | | query.log-static-assets-access false default | | query.max-clock-skew-adjustment 0s default | | reporter.grpc.discovery.min-peers 3 default | | reporter.grpc.retry.max 3 default | | reporter.grpc.tls.enabled false default | | reporter.grpc.tls.skip-host-verify false default | | reporter.type grpc default | | sampling.strategies-reload-interval 0s default | | span-storage.type memory user-assigned | | status.http.host-port :14269 default | ------------------------------------------------------------------------------- ``` ## How was this change tested? - I tested this function by adding some variables using the viper library., calling the CLI command to check them and comparing them in both key and value. ## Checklist - [X] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [X] I have signed all commits - [X] I have added unit tests for the new functionality - [X] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: Guilherme Mafra da Costa <g.mafra.costa@gmail.com> Signed-off-by: Guilherme Mafra <81496731+gmafrac@users.noreply.github.com> Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
yurishkuro
added a commit
that referenced
this issue
Mar 11, 2024
<!-- !! Please DELETE this comment before posting. We appreciate your contribution to the Jaeger project! 👋🎉 --> ## Which problem is this PR solving? - <!-- Example: Resolves #123 --> Resolves #5260 ## Description of the changes - ## How was this change tested? - ## Checklist - [ ] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [ ] I have signed all commits - [ ] I have added unit tests for the new functionality - [ ] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` Signed-off-by: Yuan Fang <yuanfang@alauda.io> Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
yurishkuro
added a commit
that referenced
this issue
Mar 11, 2024
<!-- !! Please DELETE this comment before posting. We appreciate your contribution to the Jaeger project! 👋🎉 --> ## Which problem is this PR solving? - <!-- Example: Resolves #123 --> ## Description of the changes - remove repetitive words ## How was this change tested? - ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` Signed-off-by: tgolang <seekseat@aliyun.com> Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
varshith257
pushed a commit
to varshith257/jaeger
that referenced
this issue
Mar 13, 2024
<!-- !! Please DELETE this comment before posting. We appreciate your contribution to the Jaeger project! 👋🎉 --> ## Which problem is this PR solving? - <!-- Example: Resolves jaegertracing#123 --> Resolves jaegertracing#5260 ## Description of the changes - ## How was this change tested? - ## Checklist - [ ] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [ ] I have signed all commits - [ ] I have added unit tests for the new functionality - [ ] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` Signed-off-by: Yuan Fang <yuanfang@alauda.io> Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com> Signed-off-by: Vamshi Maskuri <gwcchintu@gmail.com>
varshith257
pushed a commit
to varshith257/jaeger
that referenced
this issue
Mar 13, 2024
<!-- !! Please DELETE this comment before posting. We appreciate your contribution to the Jaeger project! 👋🎉 --> ## Which problem is this PR solving? - <!-- Example: Resolves jaegertracing#123 --> ## Description of the changes - remove repetitive words ## How was this change tested? - ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` Signed-off-by: tgolang <seekseat@aliyun.com> Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com> Signed-off-by: Vamshi Maskuri <gwcchintu@gmail.com>
varshith257
pushed a commit
to varshith257/jaeger
that referenced
this issue
Mar 13, 2024
<!-- !! Please DELETE this comment before posting. We appreciate your contribution to the Jaeger project! 👋🎉 --> ## Which problem is this PR solving? - <!-- Example: Resolves jaegertracing#123 --> Resolves jaegertracing#5260 ## Description of the changes - ## How was this change tested? - ## Checklist - [ ] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [ ] I have signed all commits - [ ] I have added unit tests for the new functionality - [ ] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` Signed-off-by: Yuan Fang <yuanfang@alauda.io> Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com> Signed-off-by: Vamshi Maskuri <gwcchintu@gmail.com>
varshith257
pushed a commit
to varshith257/jaeger
that referenced
this issue
Mar 13, 2024
<!-- !! Please DELETE this comment before posting. We appreciate your contribution to the Jaeger project! 👋🎉 --> ## Which problem is this PR solving? - <!-- Example: Resolves jaegertracing#123 --> ## Description of the changes - remove repetitive words ## How was this change tested? - ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` Signed-off-by: tgolang <seekseat@aliyun.com> Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com> Signed-off-by: Vamshi Maskuri <gwcchintu@gmail.com>
yurishkuro
added a commit
that referenced
this issue
Sep 4, 2024
<!-- !! Please DELETE this comment before posting. We appreciate your contribution to the Jaeger project! 👋🎉 --> ## Which problem is this PR solving? - <!-- Example: Resolves #123 --> ## Description of the changes - ## How was this change tested? - ## Checklist - [ ] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [ ] I have signed all commits - [ ] I have added unit tests for the new functionality - [ ] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: Mend Renovate <bot@renovateapp.com> Signed-off-by: Yuri Shkuro <github@ysh.us> Signed-off-by: Yuri Shkuro <yurishkuro@users.noreply.github.com> Co-authored-by: Mend Renovate <bot@renovateapp.com>
yurishkuro
added a commit
that referenced
this issue
Oct 23, 2024
<!-- !! Please DELETE this comment before posting. We appreciate your contribution to the Jaeger project! 👋🎉 --> ## Which problem is this PR solving? - <!-- Example: Resolves #123 --> This PR addresses the issue of verifying Kafka e2e integration tests for otlp_json formats. ## Description of the changes - Verified if the Kafka e2e integration tests run for otlp_json formats. - Used a fork of mine (github.com/joeyyy09/opentelemetry-collector-contrib) to incorporate necessary changes and verify the process. ## How was this change tested? - Ran the Kafka e2e integration tests locally using the modified configuration. ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` Signed-off-by: joeyyy09 <menteharshith@gmail.com> Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
REST API will be necessary for collecting span from a web browser.
see jaegertracing/jaeger-client-node#109
The text was updated successfully, but these errors were encountered: