Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Remove repetitive words #5265

Merged
merged 2 commits into from
Mar 11, 2024
Merged

[chore] Remove repetitive words #5265

merged 2 commits into from
Mar 11, 2024

Conversation

tgolang
Copy link
Contributor

@tgolang tgolang commented Mar 11, 2024

Which problem is this PR solving?

Description of the changes

  • remove repetitive words

How was this change tested?

Checklist

Signed-off-by: tgolang <seekseat@aliyun.com>
@tgolang tgolang requested a review from a team as a code owner March 11, 2024 07:52
@tgolang tgolang requested a review from pavolloffay March 11, 2024 07:52
Copy link

@Vivekgaddigi Vivekgaddigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@yurishkuro yurishkuro changed the title chore: remove repetitive words [chore] Remove repetitive words Mar 11, 2024
@yurishkuro yurishkuro enabled auto-merge (squash) March 11, 2024 12:38
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.09%. Comparing base (0b87fa5) to head (cb1187a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5265      +/-   ##
==========================================
- Coverage   95.11%   95.09%   -0.03%     
==========================================
  Files         339      339              
  Lines       16511    16511              
==========================================
- Hits        15705    15701       -4     
- Misses        619      621       +2     
- Partials      187      189       +2     
Flag Coverage Δ
cassandra-3.x 26.53% <ø> (ø)
cassandra-4.x 26.53% <ø> (ø)
elasticsearch-5.x 21.77% <ø> (ø)
elasticsearch-6.x 21.77% <ø> (ø)
elasticsearch-7.x 21.85% <ø> (ø)
elasticsearch-8.x 21.92% <ø> (ø)
grpc-badger 19.23% <ø> (ø)
kafka 14.66% <ø> (ø)
opensearch-1.x 21.84% <ø> (-0.02%) ⬇️
opensearch-2.x 21.84% <ø> (ø)
unittests 92.71% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro merged commit ccecb7f into jaegertracing:main Mar 11, 2024
35 checks passed
varshith257 pushed a commit to varshith257/jaeger that referenced this pull request Mar 13, 2024
<!--
!! Please DELETE this comment before posting.
We appreciate your contribution to the Jaeger project! 👋🎉
-->

## Which problem is this PR solving?
- <!-- Example: Resolves jaegertracing#123 -->

## Description of the changes
-  remove repetitive words

## How was this change tested?
- 

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [x] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `yarn lint` and `yarn test`

Signed-off-by: tgolang <seekseat@aliyun.com>
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
Signed-off-by: Vamshi Maskuri <gwcchintu@gmail.com>
varshith257 added a commit to varshith257/jaeger that referenced this pull request Mar 13, 2024
varshith257 pushed a commit to varshith257/jaeger that referenced this pull request Mar 13, 2024
<!--
!! Please DELETE this comment before posting.
We appreciate your contribution to the Jaeger project! 👋🎉
-->

## Which problem is this PR solving?
- <!-- Example: Resolves jaegertracing#123 -->

## Description of the changes
-  remove repetitive words

## How was this change tested?
- 

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [x] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `yarn lint` and `yarn test`

Signed-off-by: tgolang <seekseat@aliyun.com>
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
Signed-off-by: Vamshi Maskuri <gwcchintu@gmail.com>
varshith257 added a commit to varshith257/jaeger that referenced this pull request Mar 13, 2024
This reverts commit f296ccd.

Signed-off-by: Vamshi Maskuri <gwcchintu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants